From owner-freebsd-stable@FreeBSD.ORG Thu Jun 23 05:48:03 2011 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8708B1065674; Thu, 23 Jun 2011 05:48:03 +0000 (UTC) (envelope-from melifaro@ipfw.ru) Received: from no.spam.no.ddos.ru (no.spam.no.ddos.ru [77.73.233.132]) by mx1.freebsd.org (Postfix) with ESMTP id 391868FC14; Thu, 23 Jun 2011 05:48:01 +0000 (UTC) Received: from ws.su29.net (v6.mpls.in [IPv6:2a02:978:2::5]) by no.spam.no.ddos.ru (Postfix) with ESMTPA id 9546F38599A; Thu, 23 Jun 2011 09:21:36 +0400 (MSD) Message-ID: <4E02CD66.2050306@ipfw.ru> Date: Thu, 23 Jun 2011 09:21:42 +0400 From: "Alexander V. Chernikov" User-Agent: Thunderbird 2.0.0.24 (X11/20100515) MIME-Version: 1.0 To: Kurt Jaeger References: <20110622121136.GC16648@home.opsec.eu> <201106221712.57278.jhb@freebsd.org> <20110622212007.GD16648@home.opsec.eu> In-Reply-To: <20110622212007.GD16648@home.opsec.eu> X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Bjoern Zeeb , Kurt Jaeger , freebsd-stable@freebsd.org, John Baldwin Subject: Re: commit PR 154469, ftp-proxy(8) bug ? X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jun 2011 05:48:03 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Kurt Jaeger wrote: > Hi! > >>> Can someone have a look at >>> >>> http://www.freebsd.org/cgi/query-pr.cgi?pr=154469 >>> >>> and commit it ? So that it ends up in 8.3 8-} ? >> Does the patch from OpenBSD fix the problem for you? > > Yes, sure. That why I sent the pr! > Yep, the patch does the right thing: Setup: FTP server: 87.51.34.132 (ftp.freebsd.org) FTP client: 10.11.0.8 (stock freebsd ftp client) GW with pf & ftp-proxy (FreeBSD 7.3) ext: em0 77.73.232.13 int: vlan3 10.11.0.1 FTP session: 23:50 [0] bibi# ftp -a 87.51.34.132 Connected to 87.51.34.132. 220 ftp.beastie.tdk.net FTP server (Version 6.00LS) ready. 331 Guest login ok, send your email address as password. 230 Guest login ok, access restrictions apply. Remote system type is UNIX. Using binary mode to transfer files. ftp> quit TCPDUMP (10.11.0.8 em0): (-lnpAs0 host 87.51.34.132) 23:51:39.487136 IP 10.11.0.8.47376 > 87.51.34.132.21: Flags [P.], ack 303, win 8326, options [nop,nop,TS val 458938281 ecr 1611018784], length 6 E..:b.@.@.TW ...W3".......E....... ........ .Z..`.2 QUIT 23:51:39.530414 IP 87.51.34.132.21 > 10.11.0.8.47376: Flags [F.], seq 303, ack 56, win 4163, options [nop,nop,TS val 1611020954 ecr 458938281], length 0 E..4..@.@...W3". .............E....CT...... `.:..Z.. Note 'server' silently closing connection TCPDUMP (GW em0): 23:56:20.405425 IP 77.73.232.13.61168 > 87.51.34.132.21: P 50:56(6) ack 303 win 4163 W3".........dn.....C....... x...sA6.QUIT 23:56:20.448332 IP 87.51.34.132.21 > 77.73.232.13.61168: . ack 56 win 257 ....dn...........&..... sA>.x... 23:56:20.448345 IP 87.51.34.132.21 > 77.73.232.13.61168: P 303:317(14) ack 56 win 257 ....dn...........8..... sA>.x...221 Goodbye. 23:56:20.448353 IP 87.51.34.132.21 > 77.73.232.13.61168: F 317:317(0) ack 56 win 257 ....dn.&............... sA>.x... Note real server transmits '221 Goodbye' After applying patch: 23:54 [0] bibi# ftp -a 87.51.34.132 Connected to 87.51.34.132. 220 ftp.beastie.tdk.net FTP server (Version 6.00LS) ready. 331 Guest login ok, send your email address as password. 230 Guest login ok, access restrictions apply. Remote system type is UNIX. Using binary mode to transfer files. ftp> quit 221 Goodbye. Note '221 Goodvye' received by ftp client -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk4CzWYACgkQwcJ4iSZ1q2lOcwCfYqknB9i1P7bfjgYVpSjkSWP1 Y8wAn3hC2pZ/OHDicCN+o3v1O5YiFZ8W =dqk/ -----END PGP SIGNATURE-----