From owner-cvs-all Sun Feb 11 10:34:45 2001 Delivered-To: cvs-all@freebsd.org Received: from garm.bart.nl (garm.bart.nl [194.158.170.13]) by hub.freebsd.org (Postfix) with ESMTP id 0C9DE37B401; Sun, 11 Feb 2001 10:34:40 -0800 (PST) Received: from daemon.chronias.ninth-circle.org (root@cable.ninth-circle.org [195.38.232.6]) by garm.bart.nl (8.10.1/8.10.1) with ESMTP id f1BIYZQ80985; Sun, 11 Feb 2001 19:34:35 +0100 (CET) Received: (from asmodai@localhost) by daemon.chronias.ninth-circle.org (8.11.1/8.11.0) id f1BIYTd06560; Sun, 11 Feb 2001 19:34:29 +0100 (CET) (envelope-from asmodai) Date: Sun, 11 Feb 2001 19:34:28 +0100 From: Jeroen Ruigrok/Asmodai To: "Andrey A. Chernov" Cc: Alexey Zelkin , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/locale lmessages.c Message-ID: <20010211193428.S406@daemon.ninth-circle.org> References: <200102111509.f1BF9Vg00411@freefall.freebsd.org> <20010211204400.A94085@nagual.pp.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2i In-Reply-To: <20010211204400.A94085@nagual.pp.ru>; from ache@nagual.pp.ru on Sun, Feb 11, 2001 at 08:44:05PM +0300 Organisation: Ninth-Circle Enterprises Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG -On [20010211 19:00], Andrey A. Chernov (ache@nagual.pp.ru) wrote: >On Sun, Feb 11, 2001 at 07:09:31 -0800, Alexey Zelkin wrote: >> phantom 2001/02/11 07:09:31 PST >> >> Modified files: >> lib/libc/locale lmessages.c >> Log: >> Don't use hardcoded struct size, use offsetof() instead (make size calculations >> dynamic) > >The same as for lnumeric/lmonetary is true here too, i.e. > >if (!ret) I'd rather prefer if (ret == NULL) or likewise constructs. More style(9) compliant and a hell of a lot more readable. -- Jeroen Ruigrok vd Werven/Asmodai asmodai@[wxs.nl|bart.nl|freebsd.org] Documentation nutter/C-rated Coder BSD: Technical excellence at its best D78D D0AD 244D 1D12 C9CA 7152 035C 1138 546A B867 I'm a child of the air, I'm a witch of the wind... To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message