Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 24 Jun 2013 13:09:48 +0200 (CEST)
From:      Julian Stacey <jhs@berklix.com>
To:        FreeBSD-gnats-submit@freebsd.org
Cc:        "Julian H. Stacey" <jhs@berklix.com>
Subject:   ports/179925: Fix for ports/mail/majordomo/Makefile dialog
Message-ID:  <201306241109.r5OB9mIb045070@land.berklix.org>
Resent-Message-ID: <201306241120.r5OBK27F006788@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         179925
>Category:       ports
>Synopsis:       Fix for ports/mail/majordomo/Makefile dialog
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jun 24 11:20:01 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Julian Stacey
>Release:        FreeBSD 9.1-RELEASE-p4 amd64
>Organization:
http://berklix.com
>Environment:
System: FreeBSD land.berklix.org 9.1-RELEASE-p4 FreeBSD 9.1-RELEASE-p4 #0: Mon Jun 17 11:42:37 UTC 2013 root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC amd64


	
>Description:
Fix for broken ports/mail/majordomo/Makefile dialog.

	
The dialog line previously worked in 8.2 but broke in 9.1 with:
        Error: Expected no more than 3 tokens for --yesno, have 4.
Reason: dialog syntax changed, man dialog:
        8.2 --yesno text height width [ yes | no ]
        9.1 --yesno text height width
Alternatives:
- 9.1 has --defaultno but 8.2 does not have --defaultno.
- a multi line .if depending on variants of uname -r would be bulky,
  & I don't need it.  When I cd majordomo I want it !

>How-To-Repeat:
	
cd /usr/ports/mail/majordomo ; make

>Fix:

	

Apply fix appended.
----------------
http://www.berklix.com/~jhs/public_html/src/bsd/fixes/FreeBSD/ports/gen/mail/majordomo/Makefile.REL=9.1-RELEASE.diff

Fix for broken majordomo.
The dialog line previously worked in 8.2 but broke in 9.1 with:
	Error: Expected no more than 3 tokens for --yesno, have 4.
Reason: dialog syntax changed, man dialog:
	8.2 --yesno text height width [ yes | no ]
	9.1 --yesno text height width
Alternatives:
- 9.1 has --defaultno but 8.2 does not have --defaultno.
- a multi line .if depending on variants of uname -r would be bulky,
  & I don't need it.  When I cd majordomo I want it !


*** 9.1-RELEASE/ports/mail/majordomo/Makefile	Fri Dec 28 12:23:25 2012
--- new-generic/ports/mail/majordomo/Makefile	Fri Dec 28 12:25:09 2012
***************
*** 41,47 ****
  
  pre-fetch:
  .if !defined(BATCH) && !defined(PACKAGE_BUILDING)
! 	${DIALOG} --yesno "WARNING: Majordomo is a really old mail list manager. The last version was released in january 2000, and there does not seem to be any updates coming. You might want to consider using mailman instead. Are you sure you want to install majordomo?" 8 70 no || ${FALSE}
  .endif
  
  post-patch:
- --- 41,47 ----
  
  pre-fetch:
  .if !defined(BATCH) && !defined(PACKAGE_BUILDING)
! 	${DIALOG} --yesno "WARNING: Majordomo is a really old mail list manager. The last version was released in january 2000, and there does not seem to be any updates coming. You might want to consider using mailman instead. Are you sure you want to install majordomo?" 8 70    || ${FALSE}
  .endif
  
  post-patch:
----------------
>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201306241109.r5OB9mIb045070>