From owner-freebsd-ports@FreeBSD.ORG  Fri Jul 22 17:54:35 2005
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
X-Original-To: freebsd-ports@FreeBSD.org
Delivered-To: freebsd-ports@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B4B0C16A5D4;
	Fri, 22 Jul 2005 17:54:33 +0000 (GMT)
	(envelope-from tataz@tataz.chchile.org)
Received: from postfix4-1.free.fr (postfix4-1.free.fr [213.228.0.62])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 57C8A44CD5;
	Fri, 22 Jul 2005 17:32:35 +0000 (GMT)
	(envelope-from tataz@tataz.chchile.org)
Received: from tatooine.tataz.chchile.org
	(vol75-8-82-233-239-98.fbx.proxad.net [82.233.239.98])
	by postfix4-1.free.fr (Postfix) with ESMTP id E5799318723;
	Fri, 22 Jul 2005 19:32:27 +0200 (CEST)
Received: by tatooine.tataz.chchile.org (Postfix, from userid 1000)
	id 96DD6407E; Fri, 22 Jul 2005 19:32:16 +0200 (CEST)
Date: Fri, 22 Jul 2005 19:32:16 +0200
From: Jeremie Le Hen <jeremie@le-hen.org>
To: Florent Thoumie <flz@xbsd.org>
Message-ID: <20050722173215.GR39292@obiwan.tataz.chchile.org>
References: <20050722150032.GP39292@obiwan.tataz.chchile.org>
	<1122050545.97024.2.camel@cream.xbsd.org>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="4VrXvz3cwkc87Wze"
Content-Disposition: inline
In-Reply-To: <1122050545.97024.2.camel@cream.xbsd.org>
User-Agent: Mutt/1.5.9i
Cc: Jeremie Le Hen <jeremie@le-hen.org>, freebsd-ports@FreeBSD.org,
	edwin@FreeBSD.org
Subject: Re: ngrep and libpcap from ports
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Jul 2005 17:54:36 -0000


--4VrXvz3cwkc87Wze
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Florent,

> > This patch will link against the libpcap from ports if it exists.
> > I'm not sure this is the correct way to write this, feel free to change
> > it's needed.
> 
> 	I wouldn't fix it that way because it would lead to unexpected 
> 	behavior.
> 
> 	I'd use base pcap includes unless WITH_PORTS_PCAP is defined 
> 	(which add pcap to LIB_DEPENDS).

Thanks for your reply.  I'll take it as the way to go it as I'm
convinced you are far more experienced in ports than I am.

Here is the updated patch.  Note nevertheless that adding
    --with-pcap-includes=${PREFIX}/include
to CONFIGURE_ARGS is required or ngrep configure script will fail
miserably with the message I showed in my previous mail.

Regards,
-- 
Jeremie Le Hen
< jeremie at le-hen dot org >< ttz at chchile dot org >

--4VrXvz3cwkc87Wze
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="ngrep_libpcap_port.patch"

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/net/ngrep/Makefile,v
retrieving revision 1.18
diff -u -r1.18 Makefile
--- Makefile	24 Feb 2005 06:28:20 -0000	1.18
+++ Makefile	22 Jul 2005 17:29:32 -0000
@@ -31,6 +31,11 @@
 
 .include <bsd.port.pre.mk>
 
+.if defined(WITH_PORTS_PCAP)
+CONFIGURE_ARGS+=--with-pcap-includes=${PREFIX}/include
+LIB_DEPENDS=	pcap.2:${PORTSDIR}/net/libpcap
+.endif
+
 post-install:
 .if !defined(NOPORTDOCS)
 	@${MKDIR} ${DOCSDIR}

--4VrXvz3cwkc87Wze--