From owner-freebsd-ports@FreeBSD.ORG Thu Oct 13 18:18:03 2005 Return-Path: X-Original-To: freebsd-ports@freebsd.org Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5359F16A41F for ; Thu, 13 Oct 2005 18:18:03 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id F15E743D46 for ; Thu, 13 Oct 2005 18:18:02 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id j9DII24e001269; Thu, 13 Oct 2005 11:18:02 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id j9DII1Yc001268; Thu, 13 Oct 2005 11:18:01 -0700 Date: Thu, 13 Oct 2005 11:18:01 -0700 From: Brooks Davis To: Scot Hetzel Message-ID: <20051013181801.GD27418@odin.ac.hmc.edu> References: <20051013132601.GA57837@Klabautermann.ks.se> <790a9fff0510130902h3b98df6mb56408a9638399a1@mail.gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="gE7i1rD7pdK0Ng3j" Content-Disposition: inline In-Reply-To: <790a9fff0510130902h3b98df6mb56408a9638399a1@mail.gmail.com> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.3 required=8.0 tests=UPPERCASE_25_50 autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu Cc: Christopher Illies , freebsd-ports@freebsd.org Subject: Re: 6.0: math/lapack fails with NO_PROFILE (fix) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Oct 2005 18:18:03 -0000 --gE7i1rD7pdK0Ng3j Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 13, 2005 at 11:02:04AM -0500, Scot Hetzel wrote: > On 10/13/05, Christopher Illies wrote: > > On my FreeBSD 6.0 system math/lapack fails to install while I have > > NO_PROFILE=3Dtrue set in /etc/make.conf. Obviously the follwing patch > > fixes this problem on my system: > > > > --- /usr/ports/math/lapack/Makefile.orig Thu Oct 13 14:47:16 > > 2005 > > +++ /usr/ports/math/lapack/Makefile Thu Oct 13 14:47:35 2005 > > @@ -215,7 +215,7 @@ > > @${ECHO} "Set ENABLE_TESTING to YES to enable testing and > > timing." > > .endif > > pre-install: > > -.if !defined(NOPROFILE) > > +.if !defined(NO_PROFILE) > > @${CAT} ${PKGDIR}/pkg-plist > ${PLIST} > > .else > > @${SED} -e /_p.a/d ${PKGDIR}/pkg-plist > ${PLIST} > > @@ -224,7 +224,7 @@ > > do-install: > > ${INSTALL_DATA} ${WRKSRC}/BLAS/SRC/libblas.* ${PREFIX}/lib > > ${INSTALL_DATA} ${WRKSRC}/SRC/liblapack.* ${PREFIX}/lib > > -.if !defined(NOPROFILE) > > +.if !defined(NO_PROFILE) > > ${INSTALL_DATA} ${WRKSRC}/BLAS/SRC/libblas_p.a ${PREFIX}/lib > > ${INSTALL_DATA} ${WRKSRC}/SRC/liblapack_p.a ${PREFIX}/lib > > .endif > > > > I seem to remember that the change from NOPROFILE to NO_PROFILE was a > > recent change that does not apply to all versions of FreeBSD. What > > would be the correct way to do this? > > > Try adding this to the port: >=20 > .if ${OSVERSION} < 600000 && defined(NOPROFILE) > NO_PROFILE=3D true > .endif Minor nit, it might be better to do it the other way around since eventually we'll stop supporting NOPROFILE. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --gE7i1rD7pdK0Ng3j Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFDTqTZXY6L6fI4GtQRApQaAJ9sAUdkg2PZFYtMfMo94d9yfccgGgCfa+n4 iptE6Vk4x+3BbcmRwbFGSPg= =fTKP -----END PGP SIGNATURE----- --gE7i1rD7pdK0Ng3j--