From owner-cvs-src@FreeBSD.ORG Thu Aug 14 13:34:00 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C7F0B37B401; Thu, 14 Aug 2003 13:34:00 -0700 (PDT) Received: from mailbox.univie.ac.at (mailbox.univie.ac.at [131.130.1.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3FB7D43F3F; Thu, 14 Aug 2003 13:33:59 -0700 (PDT) (envelope-from l.ertl@univie.ac.at) Received: from localhost.localdomain (adslle.cc.univie.ac.at [131.130.102.11]) by mailbox.univie.ac.at (8.12.2/8.12.2) with ESMTP id h7EKXkQN141452; Thu, 14 Aug 2003 22:33:48 +0200 Date: Thu, 14 Aug 2003 22:33:45 +0200 (CEST) From: Lukas Ertl To: Nate Lawson In-Reply-To: <20030814132424.N93994@root.org> Message-ID: <20030814223052.O744@leelou.in.tern> References: <20030814184108.AE45F37B49A@hub.freebsd.org> <20030814125213.X93797@root.org> <20030814220900.D744@leelou.in.tern> <20030814132424.N93994@root.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-DCC-ZID-Univie-Metrics: mailbox 4251; Body=5 Fuz1=5 Fuz2=5 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Robert Watson cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/growfs debug.c debug.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Aug 2003 20:34:01 -0000 On Thu, 14 Aug 2003, Nate Lawson wrote: > On Thu, 14 Aug 2003, Lukas Ertl wrote: > > On Thu, 14 Aug 2003, Nate Lawson wrote: > > > > > On Thu, 14 Aug 2003, Robert Watson wrote: > > > > Modified files: > > > > sbin/growfs debug.c debug.h > > > > Log: > > > > Commit 1 of 2 to fix ffsinfo(8) for UFS2. > > > > > > Nice. I have been working on UFS2 support for growfs so if you have any > > > work in that area, let me know. Most of it is sblock-related. > > > > I wasn't aware that growfs has issues with UFS2. What are the problems? > > The number one problem is the code sucks. No one is willing to maintain > it because of this. Oh. :-) > The number two problem is that not enough testing has been done with > growfs on UFS2. Feel free to do this and report any problems. I've successfully grown UFS2 filesystems residing on vinum volumes in the past, but I didn't do I regularly. > The actual problem I am addressing is larger than growfs. Basically, any > time a sblock change is made, every UFS utility in the system has to be > updated and growfs has not kept up. So I have extracted sblock updating > into a routine that is shared between the kernel and userland so that it's > only in one place in the code. But more work is needed before it can be > committed. Well, I'd say that libufs is already a right step in this direction. I would have already patched growfs to use libufs, but growfs somehow seems a little bit too much like voodoo. :-) regards, le -- Lukas Ertl eMail: l.ertl@univie.ac.at UNIX Systemadministrator Tel.: (+43 1) 4277-14073 Vienna University Computer Center Fax.: (+43 1) 4277-9140 University of Vienna http://mailbox.univie.ac.at/~le/