From owner-cvs-src@FreeBSD.ORG Sun Feb 10 14:41:29 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A7C8A16A418 for ; Sun, 10 Feb 2008 14:41:29 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.153]) by mx1.freebsd.org (Postfix) with ESMTP id 3E13913C47E for ; Sun, 10 Feb 2008 14:41:28 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: by fg-out-1718.google.com with SMTP id 16so3694698fgg.35 for ; Sun, 10 Feb 2008 06:41:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; bh=N+0sojNhxN5Do6lQ0kJyCVV+5Yt4hDIp1CYLonk/Oh0=; b=u4inukJxvC6MNuYjsYfzKn24INGKPlTb/+0W7He0fzpOOqOuNETlKW3scmvhtkNGPpAX/rYkzrdF4gDtvH+bapGWuObi4W7UTtuGgnJJbsCKYvWAh3SxX1fHxSouv2DiO07BTCCYYunVxKUreNkxa4SyEwO6V6lTovOVUnTNsZE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=vwuhsUqL5ico6IqPGZvksqrl0mzwi2KwefvsKTnr5lrAPwCxyIz/B56UHafBjivyacTezYWkNtWuf7D1nhZ+TMGjN48lnBeblHHHffNkJDvmR5FBsGFrkuv8aafqT8pFuLoMl9IPWY+2WIsbDNUk71CjoMoPt0CJPXaYbXfeFww= Received: by 10.86.76.16 with SMTP id y16mr14087476fga.23.1202654487180; Sun, 10 Feb 2008 06:41:27 -0800 (PST) Received: by 10.86.30.17 with HTTP; Sun, 10 Feb 2008 06:41:27 -0800 (PST) Message-ID: <3bbf2fe10802100641k4ebbf44fgc32978175678cb22@mail.gmail.com> Date: Sun, 10 Feb 2008 15:41:27 +0100 From: "Attilio Rao" Sender: asmrookie@gmail.com To: "Robert Watson" In-Reply-To: <20080210143313.W90254@fledge.watson.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200802092137.m19Lbsiu098036@repoman.freebsd.org> <20080210113949.GN57756@deviant.kiev.zoral.com.ua> <20080210120359.A97821@fledge.watson.org> <3bbf2fe10802100449r1b673bbfl3e41a419b08c0@mail.gmail.com> <20080210143313.W90254@fledge.watson.org> X-Google-Sender-Auth: 24d26ebefc40c4e5 Cc: Kostik Belousov , cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/sys lockmgr.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Feb 2008 14:41:29 -0000 2008/2/10, Robert Watson : > > On Sun, 10 Feb 2008, Attilio Rao wrote: > > >> > I think this shall be MFCed to RELENG_7 and RELENG_7_0. > >> > >> ... once it no longer breaks the tinderbox? > >> > >> BTW, at this point 7.0 is basically closed to any further changes. Anyone > >> planning on getting things in to 7.x needs to be thinking about either > >> errata notices (for really critical things) and 7.1. > > > > Buh! I'm very sorry for this. Really, this needed to be better croaked. It > > needs to include sys/lock.h for any lockmgr.h consumer (making lock.h a > > pre-requirement in lockmgr usage). This is going to be a little bit of work. > > > > For the moment I will revert this change, doing a better stub later, once > > other details about lockmgr are refined. > > > Or temporarily nested include lock.h from lockmgr.h. I'm pretty sure that all > consumers of struct lock pretty much include _lock.h, so if there's a > widespread dependency you could also move whatever the definitions are to > _lock.h. As long as this is also temporary code, I would prefer to move lock.h into lockmgr.h as solution. I don't want to touch _lock.h as traditionally (about all the other locking primitives too) this only includes structures definition and related macros (which has nothing to do with this specific problem). Attilio -- Peace can only be achieved by understanding - A. Einstein