From owner-freebsd-ports-bugs@freebsd.org Mon Oct 31 05:25:47 2016 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5B728C27CD7 for ; Mon, 31 Oct 2016 05:25:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4142F165E for ; Mon, 31 Oct 2016 05:25:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u9V5Pl3K052783 for ; Mon, 31 Oct 2016 05:25:47 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 213285] [NEW PORT] audio/lv2: an open standard for audio plugins Date: Mon, 31 Oct 2016 05:25:47 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: jbeich@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Oct 2016 05:25:47 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D213285 Jan Beich (mail not working) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jbeich@FreeBSD.org --- Comment #1 from Jan Beich (mail not working) --- Comment on attachment 175509 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D175509 new port (update) $ portlint -AC FATAL: Makefile: [15]: use a tab (not space) after a variable name FATAL: Makefile: [19]: use a tab (not space) after a variable name FATAL: Makefile: [21]: use a tab (not space) after a variable name FATAL: Makefile: [23]: use a tab (not space) after a variable name FATAL: Makefile: [25]: use a tab (not space) after a variable name 5 fatal errors and 0 warnings found. > XCOMMENT=3D LV2 Package Can you give a better description of what the package is about? Perhaps, extract and reword parts of pkg-descr or take/mix description(s) from other distributions (e.g. Arch Linux, Gentoo, PkgSrc, Debian). https://www.freebsd.org/doc/en/books/porters-handbook/makefile-comment.html > XLIB_DEPENDS=3D libsndfile.so:audio/libsndfile libfontconfig.so:x11-fo= nts/fontconfig libfreetype.so:print/freetype2 Wrap long lines to be readable on 80 column terminal. Auto-wrapping in text editors often looks ugly while long lines are hard to review. Also, sort dependencies by package origin (i.e. port directory). > XUSES=3D pkgconfig python:build tar:bzip2 waf gettext-runtime [...] > XUSE_GNOME=3D gtk20 pango atk cairo gdkpixbuf2 glib20 Prefer alphabetic sorting in USE* variables unless you have a rationale to = do otherwise. > XCONFLICTS_INSTALL=3D lv2core For better visibility maybe move just under _DEPENDS section. > XCONFIGURE_TARGET=3D configure This is already the default value. > XNLS_USES=3D gettext This is nop unless OPTIONS_DEFINE contains NLS and the build is somehow instructed to disable gettext dependency if the option is disabled. > XUSE_GNOME=3D gtk20 pango atk cairo gdkpixbuf2 glib20 To avoid confusion don't place global variables *after* those tied to a specific option such as NLS i.e., USES=3D ... USE_BAR=3D ... USE_QUX=3D ... OPTIONS_DEFINE=3D ... TEST_USES=3D ... vs. USES=3D ... OPTIONS_DEFINE=3D ... TEST_USES=3D ... USE_BAR=3D ... USE_QUX=3D ... > X.if defined(BATCH) || defined(PACKAGE_BUILDING) > XMAKE_ARGS+=3D --verbose > X.endif No longer necessary after ports r421635 + ports r423928. > X @${REINPLACE_CMD} -e 's/autowaf\.build_pc(bld, '\''LV2CORE'\'', LV2CORE= _VERSION,.*/bld\(features =3D '\''subst'\'',source =3D '\''lv2core\.pc\.in'= \'',target =3D '\''lv2core\.pc'\'',install_path =3D '\''\$$\{LIBDIR\}data\/= pkgconfig'\'',PREFIX =3D bld\.env\.PREFIX,INCLUDEDIR =3D bld\.env\.INCLUDED= IR,VERSION =3D LV2CORE_VERSION\)/g' ${WRKSRC}/lv2/lv2plug.in/ns/lv2core/wsc= ript This line is hard to read. Use a patch under files/ directory unless the li= ne changes on every release. Any text editor that handles diff(1) output (e.g. Emacs, Vim) should be able to highlight changes within and facilitate edits. > Xpost-install: > X @${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/lv2/eg-amp.lv2/amp.so > X @${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/lv2/eg-fifths.lv2/fifths.so > X @${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/lv2/eg-metro.lv2/metro.so > X @${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/lv2/eg-midigate.lv2/midigate.so > X @${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/lv2/eg-params.lv2/params.so > X @${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/lv2/eg-sampler.lv2/sampler.so > X @${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/lv2/eg-sampler.lv2/sampler_ui.so > X @${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/lv2/eg-scope.lv2/examploscope.so > X @${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/lv2/eg-scope.lv2/examploscope_ui= .so This can be simplified to a bit more future-proof variant: post-install: # Waf doesn't have built-in strip support @${FIND} ${STAGEDIR}${PREFIX}/lib/lv2/ \ -name '*.so' -exec ${STRIP_CMD} {} + >Xbin/lv2specgen.py If the file uses python you need USES=3Dpython:run, or in this case just USES=3Dpython (without arguments). And you may need USES=3Dshebang as "python" from lang/python may not be installed. https://www.freebsd.org/doc/en/books/porters-handbook/uses-shebangfix.html --=20 You are receiving this mail because: You are the assignee for the bug.=