From owner-cvs-all@FreeBSD.ORG  Tue May 22 10:44:50 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id A889916A469;
	Tue, 22 May 2007 10:44:50 +0000 (UTC) (envelope-from des@des.no)
Received: from tim.des.no (tim.des.no [194.63.250.121])
	by mx1.freebsd.org (Postfix) with ESMTP id 4D81313C489;
	Tue, 22 May 2007 10:44:50 +0000 (UTC) (envelope-from des@des.no)
Received: from tim.des.no (localhost [127.0.0.1])
	by spam.des.no (Postfix) with ESMTP id C0DC42084;
	Tue, 22 May 2007 12:44:42 +0200 (CEST)
X-Spam-Tests: AWL
X-Spam-Learn: disabled
X-Spam-Score: 0.0/3.0
X-Spam-Checker-Version: SpamAssassin 3.1.7 (2006-10-05) on tim.des.no
Received: from dwp.des.no (des.no [80.203.243.180])
	by smtp.des.no (Postfix) with ESMTP id 3BE392083;
	Tue, 22 May 2007 12:44:42 +0200 (CEST)
Received: by dwp.des.no (Postfix, from userid 1001)
	id 1289F57AF; Tue, 22 May 2007 12:44:42 +0200 (CEST)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: Robert Watson <rwatson@FreeBSD.org>
References: <200705192051.l4JKp0rF074703@repoman.freebsd.org>
	<20070522003856.GX21795@elvis.mu.org>
	<20070522112825.U50138@fledge.watson.org>
Date: Tue, 22 May 2007 12:44:41 +0200
In-Reply-To: <20070522112825.U50138@fledge.watson.org> (Robert Watson's
	message of "Tue\, 22 May 2007 11\:28\:46 +0100 \(BST\)")
Message-ID: <863b1pyw6e.fsf@dwp.des.no>
User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.3 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: cvs-src@FreeBSD.org, Alfred Perlstein <alfred@freebsd.org>,
	Andre Oppermann <andre@FreeBSD.org>, cvs-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern uipc_syscalls.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 22 May 2007 10:44:50 -0000

Robert Watson <rwatson@FreeBSD.org> writes:
> Alfred Perlstein <alfred@freebsd.org> writes:
> > Is this the same bug that used to be in sendfile but got corrected
> > some years back?
> Dunno, but it sounds like we really need a comprehensive set of
> edge-case tests for sendfile.

This was not an edge case.  The edge case (no offset, no length, no
header) was the one that worked; it was the non-trivial case (non-zero
offset, explicit length, non-empty header) that was broken.  Nobody
noticed because existing code (Apache, ftpd) only exercises the edge
case.

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no