From owner-freebsd-emulation@FreeBSD.ORG Wed Mar 12 10:48:59 2008 Return-Path: Delivered-To: emulation@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 03DA21065672; Wed, 12 Mar 2008 10:48:59 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from redbull.bpaserver.net (redbullneu.bpaserver.net [213.198.78.217]) by mx1.freebsd.org (Postfix) with ESMTP id 840948FC1F; Wed, 12 Mar 2008 10:48:58 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from outgoing.leidinger.net (p54A5695A.dip.t-dialin.net [84.165.105.90]) by redbull.bpaserver.net (Postfix) with ESMTP id 8C90E2E0EF; Wed, 12 Mar 2008 11:48:25 +0100 (CET) Received: from webmail.leidinger.net (webmail.leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id 4DE847883B; Wed, 12 Mar 2008 11:46:16 +0100 (CET) Received: (from www@localhost) by webmail.leidinger.net (8.14.2/8.13.8/Submit) id m2CAkFYf039347; Wed, 12 Mar 2008 11:46:15 +0100 (CET) (envelope-from Alexander@Leidinger.net) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde MIME library) with HTTP; Wed, 12 Mar 2008 11:46:15 +0100 Message-ID: <20080312114615.tcssgxahkck04c8s@webmail.leidinger.net> X-Priority: 3 (Normal) Date: Wed, 12 Mar 2008 11:46:15 +0100 From: Alexander Leidinger To: pav@FreeBSD.org References: <200803112345.m2BNj4Hj051138@repoman.freebsd.org> <20080312110416.rvewfpfrqcgswo0c@webmail.leidinger.net> <1205316953.51779.13.camel@pav.hide.vol.cz> In-Reply-To: <1205316953.51779.13.camel@pav.hide.vol.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable User-Agent: Internet Messaging Program (IMP) H3 (4.1.5) / FreeBSD-8.0 X-BPAnet-MailScanner-Information: Please contact the ISP for more information X-BPAnet-MailScanner: Found to be clean X-BPAnet-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-14.9, required 6, BAYES_00 -15.00, RDNS_DYNAMIC 0.10) X-BPAnet-MailScanner-From: alexander@leidinger.net X-Spam-Status: No Cc: emulation@FreeBSD.org, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/Mk bsd.port.mk bsd.port.subdir.mk bsd.xorg.mk X-BeenThere: freebsd-emulation@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Development of Emulators of other operating systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Mar 2008 10:48:59 -0000 Quoting Pav Lucistnik (from Wed, 12 Mar 2008 =20 11:15:53 +0100): > Alexander Leidinger p=C3=AD=C5=A1e v st 12. 03. 2008 v 11:04 +0100: >> Quoting Pav Lucistnik (from Tue, 11 Mar 2008 >> 23:45:04 +0000 (UTC)): >> >> > - Teach USE_LDCONFIG to do the right thing when used with =20 >> USE_LINUX_PREFIX >> > >> > PR: ports/118212 >> > http://www.FreeBSD.org/cgi/query-pr.cgi?pr=3D118212 >> > Original patch: vd >> > Patch by: pav >> >> I would like to know why emulation@ was not in the loop for this. >> >> At >> http://www.leidinger.net/FreeBSD/port-patches/Mk:bsd.port.mk.diff > > I wasn't aware of this patch. Is it mentioned in a PR assigned to > portmgr anywhere? No PR. I mentioned it once on emulation@ I think. But it's been a =20 while. I would have expected that a linux related patch would be =20 presented for review on emulation@. > If I ignore not-ldconfig related changes in your patch, the > functionality should be equivalent. I do not need to set > NO_LDCONFIG_MTREE, because that code branch is never reached. Good. > My code goes like if (linux) { do linux stuff } else { do native stuff } > Your code went like if (linux) { setup some variables } else { setup > some variables} endif; do { common stuff }. Yes (regarding the behavior of my patch). > Only difference I see is that you condition the use of linux mdconfig by > presence of USE_LINUX, I need USE_LINUX_PREFIX, which is more strict, I > think. It depends upon your point of view: - we have ports which use USE_LINUX but not USE_LINUX_PREFIX - every port (except the base ports) needs to use USE_LINUX (the base ports are very special, we use ldconfig by hand there anyway) - Ports which don't install into LINUXBASE have no business using USE_LDCONFIG (libs which need to be cached for the run-time linker need to go into LINUXBASE) So it would be stricter in my point of view to use USE_LINUX. I can =20 understand when you say, that it is stricter by using USE_LINUX_PREFIX =20 (a different point of view). The question is now, if USE_LINUX_PREFIX is sufficient. Do we have =20 ports which install into LOCALBASE and LINUXBASE, and if yes, do they =20 install libs into LINUXBASE? emulation@ does not own a port which =20 installs into both, but emulation@ does not own all linux ports. The =20 nvidia driver installs into both, but does it _need_ (which is !=3D =20 "use") USE_LDCONFIG (I haven't checked)? Every port which installs into both locations, needs to use USE_LINUX, =20 but may not use USE_LINUX_PREFIX. So I would say it is at least =20 failsave to make this dependent upon USE_LINUX. It may be beneficial =20 to also check the argument for USE_LDCONFIG in the linux case. Only =20 "yes" (or similar) makes sense here. BTW: Thanks for working on this, it's on my TODO list for too long. Bye, Alexander. --=20 Some people cause happiness wherever they go; others, whenever they go. http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID =3D B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID =3D 72077137