From owner-cvs-src@FreeBSD.ORG  Wed Jul 28 18:28:34 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 8F13916A4CE; Wed, 28 Jul 2004 18:28:34 +0000 (GMT)
Received: from cs.rice.edu (cs.rice.edu [128.42.1.30])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 6E63643D60; Wed, 28 Jul 2004 18:28:34 +0000 (GMT)
	(envelope-from alc@cs.rice.edu)
Received: from localhost (calypso.cs.rice.edu [128.42.1.127])
	by cs.rice.edu (Postfix) with ESMTP id 02DD24ABD9;
	Wed, 28 Jul 2004 13:28:33 -0500 (CDT)
Received: from cs.rice.edu ([128.42.1.30])
 by localhost (calypso.cs.rice.edu [128.42.1.127]) (amavisd-new, port 10024)
 with LMTP id 10434-01-91; Wed, 28 Jul 2004 13:28:33 -0500 (CDT)
Received: by cs.rice.edu (Postfix, from userid 19572)
	id A2E194ABD8; Wed, 28 Jul 2004 13:28:33 -0500 (CDT)
Date: Wed, 28 Jul 2004 13:28:33 -0500
From: Alan Cox <alc@cs.rice.edu>
To: Alan Cox <alc@FreeBSD.org>
Message-ID: <20040728182833.GC18577@cs.rice.edu>
References: <200407281823.i6SIN8pQ006108@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200407281823.i6SIN8pQ006108@repoman.freebsd.org>
User-Agent: Mutt/1.4.2i
X-Virus-Scanned: by amavis-20030616-p7 at cs.rice.edu
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/vm vm_object.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Jul 2004 18:28:34 -0000

I would appreciate it if someone would volunteer to back port these
changes to -STABLE.

Regards,
Alan

On Wed, Jul 28, 2004 at 06:23:08PM +0000, Alan Cox wrote:
> alc         2004-07-28 18:23:08 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/vm               vm_object.c 
>   Log:
>   Correct a very old error in both vm_object_madvise() (originating in
>   vm/vm_object.c revision 1.88) and vm_object_sync() (originating in
>   vm/vm_map.c revision 1.36): When descending a chain of backing objects,
>   both use the wrong object's backing offset.  Consequently, both may
>   operate on the wrong pages.
>   
>   Quoting Matt, "This could be responsible for all of the sporatic madvise
>   oddness that has been reported over the years."
>   
>   Reviewed by:    Matt Dillon
>   
>   Revision  Changes    Path
>   1.329     +2 -2      src/sys/vm/vm_object.c