From nobody Tue Mar 31 09:55:07 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4flNlJ01Kmz6WcP7 for ; Tue, 31 Mar 2026 09:55:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4flNlH5NM6z3kSt for ; Tue, 31 Mar 2026 09:55:07 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774950907; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=V6avpiD9wuOj+0wZydPtuVkkcJxIQ7sUufcfdMFe/QA=; b=xf6WbSprP5ri6Iat+7ktYnED/b0WmWAyzyhSbSek3xKt93aoFdr1lv3h26Z3csbz36RL8W Ervz/vM5jxzANiDloi/wR3sWVKgWTiVqq53yf2McjvDtsUAF2/2GZgZobaPucECHMMep+/ k9ir3xpy+RHXnATYfbFkt6hJKoIiuPe/3yOL3ha4+KOYkKzA4FD0avN+97aFgMTNHRCJ2K AcU0C5bA9OgibDTYzDiJ7aJfPe2drhD3c0SQ5iYnK6JFBjtb9gBu+IjUay06qL2KfG2kRW C8ToIx2qqmfVkORl2sNM9FsK0u+8NbFxXq70FLSXm7HnFrC0R1AeiewR3TJd+g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1774950907; a=rsa-sha256; cv=none; b=GVi6a6GrwKN/tWwyIi2X1CXyFLNSUPvhnT3SHbNmtR2TkYaVSxGb7SJ3VK/3st9o3W3+AL JumoxxXqf8bfuuQPapvW/irOgLkqRHHMphL5HURVDg2RqLi3Sk2h0aPSxRBRnDt9zefkj0 6OJeGNwfhQHH02fot1hBs6niM65WFdPEj+zpPfEFQOlRdGX8s/csMuOblZp/zc+rol8qrm GwB4lqY0FOeWnQNsjlf178t+fhvnvmbyk653zEaa+DckgBoE6p8lIXnBWEOhA/AAtC4NqI AybQQWZKuBpfrOsa5a8aTLAOuw1MGBfKG6oDq/bFyn+D20ImpL+07UnUzAjrpA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774950907; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=V6avpiD9wuOj+0wZydPtuVkkcJxIQ7sUufcfdMFe/QA=; b=S6rsS//TyN1AfXzHKQmz3m/28WKkJBzN/xxtN+FnlwB7w2Kn25zorJvos3Rmyr/mIR3jL2 ZfsJ9Fu21TznqxsCE3syhT8Rf5tKiyfwA9Yyb2H2P3jcjnTp5Y18I/eXi62WvX/4eaN+Pl 4RkPA1Ed4iV1k/vxxUHwg5ssrL5/2UVj7UHwmOaGjarl2UM9tKLGXyFyPDO810Z97RSNU1 qurrc2UEl/sOyvwByw+lQmEhtDQ0J2LYEgj+ugLao4o6eDJOkGDriRyonsGG60ViQxpY3h 8SLcm6Wd550Nc0r53za/oKKv2jMgR2WzxyJrj127tpYo/+AC4hFWdIP5tKvpQA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4flNlH4Wjgz7h2 for ; Tue, 31 Mar 2026 09:55:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3cdc3 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 31 Mar 2026 09:55:07 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Christos Margiolis Subject: git: 1edf301bbb97 - stable/15 - sound: Remove SND_DIAGNOSTIC section in buffer.c List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 1edf301bbb97dca6b22c13d566ee4fa3d15988c8 Auto-Submitted: auto-generated Date: Tue, 31 Mar 2026 09:55:07 +0000 Message-Id: <69cb99fb.3cdc3.77e14853@gitrepo.freebsd.org> The branch stable/15 has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=1edf301bbb97dca6b22c13d566ee4fa3d15988c8 commit 1edf301bbb97dca6b22c13d566ee4fa3d15988c8 Author: Christos Margiolis AuthorDate: 2026-03-24 10:31:48 +0000 Commit: Christos Margiolis CommitDate: 2026-03-31 09:53:16 +0000 sound: Remove SND_DIAGNOSTIC section in buffer.c The purpose of this has not been documented, but it seems like it makes it possible to view the maximum number of bytes that passed to sndbuf_feed(), as well as the maximum number of cycles taken inside its main loop. These do not seem particularly useful anymore. Sponsored by: The FreeBSD Foundation MFC after: 1 week Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D55989 (cherry picked from commit 4324e0fa71f85f274013100d912584a042c9909e) --- sys/dev/sound/pcm/buffer.c | 26 -------------------------- 1 file changed, 26 deletions(-) diff --git a/sys/dev/sound/pcm/buffer.c b/sys/dev/sound/pcm/buffer.c index 1db9e5661dc8..0c574ae2908c 100644 --- a/sys/dev/sound/pcm/buffer.c +++ b/sys/dev/sound/pcm/buffer.c @@ -506,29 +506,11 @@ sndbuf_dispose(struct snd_dbuf *b, u_int8_t *to, unsigned int count) return 0; } -#ifdef SND_DIAGNOSTIC -static uint32_t snd_feeder_maxfeed = 0; -SYSCTL_UINT(_hw_snd, OID_AUTO, feeder_maxfeed, CTLFLAG_RD, - &snd_feeder_maxfeed, 0, "maximum feeder count request"); - -static uint32_t snd_feeder_maxcycle = 0; -SYSCTL_UINT(_hw_snd, OID_AUTO, feeder_maxcycle, CTLFLAG_RD, - &snd_feeder_maxcycle, 0, "maximum feeder cycle"); -#endif - /* count is number of bytes we want added to destination buffer */ int sndbuf_feed(struct snd_dbuf *from, struct snd_dbuf *to, struct pcm_channel *channel, struct pcm_feeder *feeder, unsigned int count) { unsigned int cnt, maxfeed; -#ifdef SND_DIAGNOSTIC - unsigned int cycle; - - if (count > snd_feeder_maxfeed) - snd_feeder_maxfeed = count; - - cycle = 0; -#endif KASSERT(count > 0, ("can't feed 0 bytes")); @@ -544,16 +526,8 @@ sndbuf_feed(struct snd_dbuf *from, struct snd_dbuf *to, struct pcm_channel *chan break; sndbuf_acquire(to, to->tmpbuf, cnt); count -= cnt; -#ifdef SND_DIAGNOSTIC - cycle++; -#endif } while (count != 0); -#ifdef SND_DIAGNOSTIC - if (cycle > snd_feeder_maxcycle) - snd_feeder_maxcycle = cycle; -#endif - return (0); }