From owner-p4-projects@FreeBSD.ORG Wed Jun 16 18:27:23 2010 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 913AE1065674; Wed, 16 Jun 2010 18:27:23 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 553431065672 for ; Wed, 16 Jun 2010 18:27:23 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id E2E408FC1C for ; Wed, 16 Jun 2010 18:27:22 +0000 (UTC) Received: by iwn7 with SMTP id 7so8201768iwn.13 for ; Wed, 16 Jun 2010 11:27:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=6zHnCdgQl80CPGOYkV41jXwZWqpOvD6ex1uvUcMmXqI=; b=uGuxTEPU3clsUEDLIkaOjZ9eK24BmmOlZi6aTm4wNDmvAZv1INxyjyolp1J8M/5cU7 REJEs6YA9rpkcKHg1RJvrbr6DA/eMk5XqEaUy0PioSFak9X/hBCy2enWw4jzprXJA0wN gt6m495JAt3jazNZRnQ0BKLLIjA8S2JNc+yH0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=RirR2qD/pAtKpaUOq15OAgL1X2/e8g8uMzhAqydDHpNKSKYwYoHh5Pot8mE31G7wYh BLrlAc1G53k++NG546WLE/bHP0cJyZGjOk2Oupki7LouPd1K4HF7J/uOjcD2sF+PyqHl K0Fv95rezzgdT3EJoaRt+70D8nSoTn+5bB72A= MIME-Version: 1.0 Received: by 10.231.124.227 with SMTP id v35mr10320265ibr.185.1276712841825; Wed, 16 Jun 2010 11:27:21 -0700 (PDT) Sender: yanegomi@gmail.com Received: by 10.231.117.201 with HTTP; Wed, 16 Jun 2010 11:27:21 -0700 (PDT) In-Reply-To: <201006161148.o5GBmrDq093951@repoman.freebsd.org> References: <201006161148.o5GBmrDq093951@repoman.freebsd.org> Date: Wed, 16 Jun 2010 11:27:21 -0700 X-Google-Sender-Auth: y09IN7YrYqt3zJxnKfl5eRAycMc Message-ID: From: Garrett Cooper To: Andrius Morkunas Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Perforce Change Reviews Subject: Re: PERFORCE change 179675 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jun 2010 18:27:23 -0000 On Wed, Jun 16, 2010 at 4:48 AM, Andrius Morkunas wro= te: > http://p4web.freebsd.org/@@179675?ac=3D10 > > Change 179675 by andrius@klevas on 2010/06/16 11:48:11 > > =A0 =A0 =A0 =A0Add NO_USE_CC. > > =A0 =A0 =A0 =A0If defined, NO_USE_CC forces USE_CC and USE_GCC to be igno= red. > =A0 =A0 =A0 =A0Before, there was no way to NOT respect USE_CC/USE_GCC var= iables. > > Affected files ... > > .. //depot/projects/soc2010/clangports/ports/Mk/bsd.compiler.mk#2 edit > > Differences ... > > =3D=3D=3D=3D //depot/projects/soc2010/clangports/ports/Mk/bsd.compiler.mk= #2 (text+ko) =3D=3D=3D=3D > > @@ -3,6 +3,11 @@ > =A0# PORTS_CXX should only be set if PORTS_CC is neither gcc nor clang > =A0PORTS_CXX?=3D =A0 =A0g++ > > +.if defined(NO_USE_CC) > +.undef USE_CC > +.undef USE_GCC > +.endif > + > =A0# Handle USE_CC > =A0.if defined(USE_CC) > =A0# Check if port requires specific compiler > @@ -35,7 +40,6 @@ > > =A0# Clang > =A0.elif !empty(PORTS_CC:Mclang*) > -# TODO: handle something like USE_CLANG here when/if there's need for th= at > =A0CC=3D =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0clang > =A0CXX=3D =A0 =A0 =A0 =A0 =A0 clang++ > =A0.else Why not just check to see if CC is defined and empty? -Garrett