From owner-freebsd-stable@FreeBSD.ORG Fri Jul 19 07:05:47 2013 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id BCF1BC9C; Fri, 19 Jul 2013 07:05:47 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) by mx1.freebsd.org (Postfix) with ESMTP id 4C9213EA; Fri, 19 Jul 2013 07:05:47 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.7/8.14.7) with ESMTP id r6J75gk4080907; Fri, 19 Jul 2013 10:05:42 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.8.3 kib.kiev.ua r6J75gk4080907 Received: (from kostik@localhost) by tom.home (8.14.7/8.14.7/Submit) id r6J75f62080898; Fri, 19 Jul 2013 10:05:41 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 19 Jul 2013 10:05:41 +0300 From: Konstantin Belousov To: Andre Albsmeier Subject: Re: FreeBSD-9.1: machine reboots during snapshot creation, LORs found Message-ID: <20130719070541.GH5991@kib.kiev.ua> References: <201305311051.03157.jhb@freebsd.org> <20130616063942.GA72803@bali> <201306171530.31208.jhb@freebsd.org> <20130704051409.GA22021@bali> <20130704052440.GG91021@kib.kiev.ua> <20130704052659.GA23398@bali> <20130704061550.GI91021@kib.kiev.ua> <20130704142919.GA1798@bali> <20130704172528.GL91021@kib.kiev.ua> <20130719053247.GA72555@bali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jxJZfy9MYHgKPwT/" Content-Disposition: inline In-Reply-To: <20130719053247.GA72555@bali> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on tom.home Cc: "freebsd-stable@freebsd.org" , John Baldwin X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jul 2013 07:05:47 -0000 --jxJZfy9MYHgKPwT/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 19, 2013 at 07:32:47AM +0200, Andre Albsmeier wrote: > On Thu, 04-Jul-2013 at 19:25:28 +0200, Konstantin Belousov wrote: > > Patch is to improve debugging. > >=20 > > I probably commit it after the issue is closed. Arguments against > > the commit is that the change imposes small performance penalty > > due to save and restore of the %ebp (I doubt that this is measureable > > by any means). Also, arguably, such change should be done for all > > functions in support.s, but bcopy() is the hot spot. >=20 > Thanks to this patch, we (you ;-) were able to track down the problem. > So how are we going to deal with this debugging patch itself? > My suggestion would be to #ifdef it somehow so on one hand it will > be availabe in future (and with bcopy being used a lot probability > is high it might help in other places), on the other hand it won't > steal cycles during normal use. This was already committed as r253328 in HEAD. I dislike the #ifdef, since the stack access is interwinned through all text, making the function forked. --jxJZfy9MYHgKPwT/ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (FreeBSD) iQIcBAEBAgAGBQJR6OVEAAoJEJDCuSvBvK1BuZkQAIg0+1fbmoREh3A0xE3Ax/oH KbbUA8w5QJf9bRfGOQbe6YP2Ux6E8aO5F9LPgyYpfEnvAO/bmmo94+HK7u5SFoK8 rW4cHASBD78IqsCne8FroNqjjpea/osAsD7HL8dbs8q0bDhYui1JsO0rvDuO59YH ZTuT+jcKu+rvDh2W/hddtL6yMK8HrcJMOpNsMCs2aMKoxTcqpdfSJ9NdlYLdNweA lVW5wT8x5gJ0MHn+oaL6epxMHVhxVLkxwjqT7LKR2acWzdvJ/n6fiMlUUixDWc9N IG12yBjQCaLTKYCtGfJzrmeiPdPKdLulF88lrawTN4W+nCUw1mj9NasoimuMhAmb kuktCcryJ72f0wVIpR8B0+C6FIUl3OSvnviSjbl4QIILPFbICjYfTWni1fty+0n2 hiQ0Vtmtb8fpsMSF4MWflRJ3FN7iz1TV6h+kkk9GaXnn7/O2H0sxnZuVk9S07OK9 u/i9Icoy8z18LYKSRJwS1C8GrXd0EYS5ECS3eggC3wxBg2t2kbGvxFcraT8PWszY m5wci5HZreEIagAl73mEk6ZZ21W8ERAVPY0RKOaje94NU4viDEBMiLlV1A0GsZNp SLzskxHdhOk7FS/3p6OKOfzKUu15Xjcio8+1MXPcbXsLSsMQr21uyXbNJ3oVTD7l AhYkM61rsiSVSOgI5Dxa =FM3Q -----END PGP SIGNATURE----- --jxJZfy9MYHgKPwT/--