From owner-svn-src-head@FreeBSD.ORG Wed Sep 3 15:17:32 2014 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A5F4694F; Wed, 3 Sep 2014 15:17:32 +0000 (UTC) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 347B618DE; Wed, 3 Sep 2014 15:17:30 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id SAA14867; Wed, 03 Sep 2014 18:17:29 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1XPCJM-000GtV-IX; Wed, 03 Sep 2014 18:17:28 +0300 Message-ID: <540730E5.1080206@FreeBSD.org> Date: Wed, 03 Sep 2014 18:16:53 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Steven Hartland , Peter Wemm Subject: Re: svn commit: r270759 - in head/sys: cddl/compat/opensolaris/kern cddl/compat/opensolaris/sys cddl/contrib/opensolaris/uts/common/fs/zfs vm References: <201408281950.s7SJo90I047213@svn.freebsd.org> <39211177.i8nn9sHiCx@overcee.wemm.org> <201409021201.15967.jhb@freebsd.org> <5405FD2C.8000901@rice.edu> <54060D1B.6020700@rice.edu> <774F8EEE96EB483DA8ACF533CF7C23F3@multiplay.co.uk> <54062268.9060603@rice.edu> <169C94ED141B435BACEADB04A4824717@multiplay.co.uk> <54070421.9030200@FreeBSD.org> <7FA917F9BB6F45FA84D8408C13359748@multiplay.co.uk> <54072C8E.7030501@FreeBSD.org> In-Reply-To: <54072C8E.7030501@FreeBSD.org> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: src-committers@FreeBSD.org, John Baldwin , Alan Cox , svn-src-all@FreeBSD.org, Dmitry Morozovsky , "Matthew D. Fuller" , svn-src-head@FreeBSD.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Sep 2014 15:17:32 -0000 on 03/09/2014 17:58 Andriy Gapon said the following: > on 03/09/2014 15:17 Steven Hartland said the following: >> ----- Original Message ----- From: "Andriy Gapon" >> >>> on 03/09/2014 11:09 Steven Hartland said the following: >>>> I'm looking to MFC this change so wanted to check if >>>> anyone had an final feedback / objections? >>> >>> I think that your changes went in a bit prematurely (little review), so perhaps >>> MFC would be premature as well. >> >> Its a change which really needs to make it into 10.1 IMO > > I think that this is the arguable point. > As I've mentioned before I have not noticed, perhaps through the fault of my > own, any reports that users need this change after Alan's pagedaemon fix(es). > Also, there is no confirmation yet that after this change ARC does not give up > its buffers too easily. > >> due to its impact on users so I don't really want to hold >> off too long. >> >> If anyone has any substantiated reason to then off course >> I'll hold off. Based on our parallel conversation I feel a need to clarify my position. The commit in question has multiple changes in it: 1. removal of KVA check, which was later correctly restored for i386 2. addition of DTrace probes 3. zfs_arc_free_target check and all the support code for it So, #1 plus later fixes is obviously correct. #2 is useful and I like it. #3 is what I have great doubts about. All of what I said in the previous emails applies to #3 exclusively. -- Andriy Gapon