From owner-cvs-all  Tue Oct 20 00:31:25 1998
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id AAA17700
          for cvs-all-outgoing; Tue, 20 Oct 1998 00:31:25 -0700 (PDT)
          (envelope-from owner-cvs-all@FreeBSD.ORG)
Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.15.68.22])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id AAA17691;
          Tue, 20 Oct 1998 00:31:22 -0700 (PDT)
          (envelope-from bde@godzilla.zeta.org.au)
Received: (from bde@localhost)
	by godzilla.zeta.org.au (8.8.7/8.8.7) id RAA07647;
	Tue, 20 Oct 1998 17:30:55 +1000
Date: Tue, 20 Oct 1998 17:30:55 +1000
From: Bruce Evans <bde@zeta.org.au>
Message-Id: <199810200730.RAA07647@godzilla.zeta.org.au>
To: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, msmith@FreeBSD.ORG
Subject: Re: cvs commit: src/bin/mkdir mkdir.c
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

>  Modified files:
>    bin/mkdir            mkdir.c 
>  Log:
>   - mkdir -m should call chmod because the high-order bits get ignored
>     by the kernel as a security feature of some sort.
>  
>  Submitted by:	Wilfredo Sanchez <wsanchez@apple.com>
>  
>  Revision  Changes    Path
>  1.12      +19 -1     src/bin/mkdir/mkdir.c

This doesn't even compile.

If it compiled, I think it would break the mode for intermediate
directories created by mkdir -p.

This bogotifies the umask() microoptimizations.

This has some style bugs.

Bruce

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message