From owner-svn-src-user@FreeBSD.ORG Mon Dec 2 15:17:26 2013 Return-Path: Delivered-To: svn-src-user@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C23E5554; Mon, 2 Dec 2013 15:17:26 +0000 (UTC) Received: from mail.allbsd.org (gatekeeper.allbsd.org [IPv6:2001:2f0:104:e001::32]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id BA4911BCC; Mon, 2 Dec 2013 15:17:25 +0000 (UTC) Received: from alph.d.allbsd.org (p4181-ipbf1307funabasi.chiba.ocn.ne.jp [123.225.173.181]) (authenticated bits=128) by mail.allbsd.org (8.14.5/8.14.5) with ESMTP id rB2FH6mG090579 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 3 Dec 2013 00:17:16 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (localhost [IPv6:::1]) (authenticated bits=0) by alph.d.allbsd.org (8.14.7/8.14.5) with ESMTP id rB2FH2HR067374; Tue, 3 Dec 2013 00:17:05 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Tue, 03 Dec 2013 00:16:28 +0900 (JST) Message-Id: <20131203.001628.1233827032249325723.hrs@allbsd.org> To: gjb@FreeBSD.org Subject: Re: svn commit: r258848 - user/hrs/releng/release From: Hiroki Sato In-Reply-To: <20131202145103.GG1839@glenbarber.us> References: <201312021440.rB2EeQa6012210@svn.freebsd.org> <20131202145103.GG1839@glenbarber.us> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 6.5 on Emacs 24.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Tue_Dec__3_00_16_28_2013_145)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.97.4 at gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (mail.allbsd.org [133.31.130.32]); Tue, 03 Dec 2013 00:17:17 +0900 (JST) X-Spam-Status: No, score=-99.1 required=13.0 tests=CONTENT_TYPE_PRESENT, SPF_SOFTFAIL,USER_IN_WHITELIST autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on gatekeeper.allbsd.org Cc: src-committers@FreeBSD.org, svn-src-user@FreeBSD.org X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Dec 2013 15:17:26 -0000 ----Security_Multipart(Tue_Dec__3_00_16_28_2013_145)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Glen Barber wrote in <20131202145103.GG1839@glenbarber.us>: gj> On Mon, Dec 02, 2013 at 02:40:26PM +0000, Hiroki Sato wrote: gj> > Author: hrs gj> > Date: Mon Dec 2 14:40:26 2013 gj> > New Revision: 258848 gj> > URL: http://svnweb.freebsd.org/changeset/base/258848 gj> > gj> > Log: gj> > Improve robustness and consistency, and remove redundant lines with no gj> > major functional change: gj> gj> > [...] gj> gj> > +if [ $($ID -u) -ne 0 ]; then gj> > + echo 1>&2 "$0: Needs to be run as root." gj> > + exit 1 gj> > +fi gj> > # The directory within which the release will be built. gj> > -CHROOTDIR="/scratch" gj> > +: ${CHROOTDIR:=/scratch} gj> > +: ${CHROOT_CMD:=chroot $CHROOTDIR} gj> > +: ${DESTDIR=:/R/} gj> > +: ${MAKEOBJDIRPREFIX:=/usr/obj} gj> > gj> gj> Please do not merge these changes to head/. It was intentional that gj> environment was not honored, as everything should be set in the gj> configuration file. gj> gj> It is possible to use the environment in the configuration file, such gj> as: gj> gj> ---- release.conf ---- gj> : ${_DESTDIR=:/R/} gj> DESTDIR=${_DESTDIR} gj> ---- release.conf ---- Everything can be overridden by a configuration file regardless of whether envvars are honored even after this change. What is the problem? I do not see negative effect assuming a conf file is used. -- Hiroki ----Security_Multipart(Tue_Dec__3_00_16_28_2013_145)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (FreeBSD) iEYEABECAAYFAlKcpEwACgkQTyzT2CeTzy0ruACgmEOLB7bMMVYEQHPvQhCB7zhE sEIAoIN1orI+WPZzSq4DfhME6fREGQ0e =MTn+ -----END PGP SIGNATURE----- ----Security_Multipart(Tue_Dec__3_00_16_28_2013_145)----