From owner-freebsd-stable@freebsd.org Sun Dec 4 13:23:04 2016 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1F8B4C63801 for ; Sun, 4 Dec 2016 13:23:04 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 02EF7104B for ; Sun, 4 Dec 2016 13:23:04 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: by mailman.ysv.freebsd.org (Postfix) id 024DFC637FF; Sun, 4 Dec 2016 13:23:04 +0000 (UTC) Delivered-To: stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 01F27C637FD for ; Sun, 4 Dec 2016 13:23:04 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9A516104A for ; Sun, 4 Dec 2016 13:23:03 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: by mail-wm0-f47.google.com with SMTP id g23so59393301wme.1 for ; Sun, 04 Dec 2016 05:23:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=LksfQsEOZdSCLNrgsxOejaxuan3H5vH5DEK3cYTSUz0=; b=XB07HWi4KcbKuRHPJdHsCAO0bU6MZdyv/UoQpLDMZwZrPddKQgCsruXzrcyATW3slU UKGfgW8B1gGvXtjp/kIP0rR6Ou/q25QufbaaZTb5BoXmKQf6MgM9fjoX307AFA6twn/b nW7ha+MrjphIKgryz0jCl1rBSiH327fuqqIcQcY1lWVqpyewFERv9Jqfgb6AFpOQJVPb eea7QweCu8YKKk9R9Ffxu4uBwDsW9E0E/t5YpfBcvBHgqFlrNhaHtitADudr3BHX0i+z Ym3mjXyUD+2RBxMTqzG5Xb5er0laB99O+c28wSQgzBjuwtxflhsYTfdHnltzwu595Xvm eNgA== X-Gm-Message-State: AKaTC01NFhCd2+tKhaFhIpjZBWWCFMAVzAqin8ip5O258Pi+gTEs9ld8jrYmZY1vPFT6WA== X-Received: by 10.25.5.215 with SMTP id 206mr20191223lff.119.1480857781720; Sun, 04 Dec 2016 05:23:01 -0800 (PST) Received: from [192.168.1.2] ([89.169.173.68]) by smtp.gmail.com with ESMTPSA id x10sm2161070lja.15.2016.12.04.05.23.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 04 Dec 2016 05:23:00 -0800 (PST) Subject: Re: if_cxgbev build error on -stable To: "stable@freebsd.org" , John Baldwin References: From: Andrey Chernov Message-ID: Date: Sun, 4 Dec 2016 16:23:00 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Dec 2016 13:23:04 -0000 It seems counter.h is included before systm.h where critical_* are declared. On 04.12.2016 16:12, Andrey Chernov wrote: > On recent i386 -stable I got: > > ... > /usr/src/sys/modules/cxgbe/if_cxgbev/../../../dev/cxgbe/t4_vf.c -o t4_vf.o > In file included from > /usr/src/sys/modules/cxgbe/if_cxgbev/../../../dev/cxgbe/t4_vf.c:37: > In file included from @/sys/counter.h:35: > ./machine/counter.h:170:3: error: implicit declaration of function > 'critical_enter' is invalid in C99 > [-Werror,-Wimplicit-function-declaration] > critical_enter(); > ^ > ./machine/counter.h:172:3: error: implicit declaration of function > 'critical_exit' is invalid in C99 > [-Werror,-Wimplicit-function-declaration] > critical_exit(); > ^ > ./machine/counter.h:172:3: note: did you mean 'critical_enter'? > ./machine/counter.h:170:3: note: 'critical_enter' declared here > critical_enter(); > ^ > In file included from > /usr/src/sys/modules/cxgbe/if_cxgbev/../../../dev/cxgbe/t4_vf.c:47: > In file included from > /usr/src/sys/modules/cxgbe/if_cxgbev/../../../dev/cxgbe/common/common.h:33: > In file included from > /usr/src/sys/modules/cxgbe/if_cxgbev/../../../dev/cxgbe/common/t4_hw.h:33: > In file included from > /usr/src/sys/modules/cxgbe/if_cxgbev/../../../dev/cxgbe/osdep.h:39: > @/sys/systm.h:196:6: error: conflicting types for 'critical_enter' > void critical_enter(void); > ^ > ./machine/counter.h:170:3: note: previous implicit declaration is here > critical_enter(); > ^ > In file included from > /usr/src/sys/modules/cxgbe/if_cxgbev/../../../dev/cxgbe/t4_vf.c:47: > In file included from > /usr/src/sys/modules/cxgbe/if_cxgbev/../../../dev/cxgbe/common/common.h:33: > In file included from > /usr/src/sys/modules/cxgbe/if_cxgbev/../../../dev/cxgbe/common/t4_hw.h:33: > In file included from > /usr/src/sys/modules/cxgbe/if_cxgbev/../../../dev/cxgbe/osdep.h:39: > @/sys/systm.h:197:6: error: conflicting types for 'critical_exit' > void critical_exit(void); > ^ > ./machine/counter.h:172:3: note: previous implicit declaration is here > critical_exit(); > ^ > 4 errors generated. > *** Error code 1 > > Stop. >