From owner-p4-projects@FreeBSD.ORG Thu Jan 3 06:15:53 2008 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 7170916A46E; Thu, 3 Jan 2008 06:15:53 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3730D16A419 for ; Thu, 3 Jan 2008 06:15:53 +0000 (UTC) (envelope-from imp@freebsd.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 2690913C459 for ; Thu, 3 Jan 2008 06:15:53 +0000 (UTC) (envelope-from imp@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m036Fr5H011210 for ; Thu, 3 Jan 2008 06:15:53 GMT (envelope-from imp@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id m036FrOH011207 for perforce@freebsd.org; Thu, 3 Jan 2008 06:15:53 GMT (envelope-from imp@freebsd.org) Date: Thu, 3 Jan 2008 06:15:53 GMT Message-Id: <200801030615.m036FrOH011207@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to imp@freebsd.org using -f From: Warner Losh To: Perforce Change Reviews Cc: Subject: PERFORCE change 132369 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jan 2008 06:15:53 -0000 http://perforce.freebsd.org/chv.cgi?CH=132369 Change 132369 by imp@imp_paco-paco on 2008/01/03 06:15:10 I think I can just remove the reference to PG_BUSY here since it changed into VOP_BUSY, and also remove the page queue locking operations. I think they are also not needed. Affected files ... .. //depot/projects/mips2-jnpr/src/sys/mips/mips/pmap.c#7 edit Differences ... ==== //depot/projects/mips2-jnpr/src/sys/mips/mips/pmap.c#7 (text+ko) ==== @@ -875,7 +875,7 @@ } void -pmap_pinit0(struct pmap *pmap) +pmap_pinit0(pmap_t pmap) { int i; @@ -896,8 +896,8 @@ * Initialize a preallocated and zeroed pmap structure, * such as one in a vmspace structure. */ -void -pmap_pinit(struct pmap *pmap) +int +pmap_pinit(pmap_t pmap) { vm_page_t ptdpg; int i; @@ -917,11 +917,16 @@ */ ptdpg = vm_page_alloc( NULL, NUSERPGTBLS, req); +#if 0 + /* I think we can just delete these, now that PG_BUSY is gone */ vm_page_lock_queues(); vm_page_flag_clear(ptdpg, PG_BUSY); /* not usually mapped*/ +#endif ptdpg->valid = VM_PAGE_BITS_ALL; +#if 0 vm_page_unlock_queues(); +#endif pmap->pm_segtab = (pd_entry_t *) MIPS_PHYS_TO_CACHED(VM_PAGE_TO_PHYS(ptdpg)); @@ -936,6 +941,8 @@ } TAILQ_INIT(&pmap->pm_pvlist); bzero(&pmap->pm_stats, sizeof pmap->pm_stats); + + return (1); } /*