From owner-svn-src-head@freebsd.org Sun Apr 9 08:12:19 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9687DD36FDC; Sun, 9 Apr 2017 08:12:19 +0000 (UTC) (envelope-from tsoome@me.com) Received: from st13p35im-asmtp001.me.com (st13p35im-asmtp001.me.com [17.164.199.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6BC433A7; Sun, 9 Apr 2017 08:12:19 +0000 (UTC) (envelope-from tsoome@me.com) Received: from process-dkim-sign-daemon.st13p35im-asmtp001.me.com by st13p35im-asmtp001.me.com (Oracle Communications Messaging Server 7.0.5.38.0 64bit (built Feb 26 2016)) id <0OO400I00UEDRU00@st13p35im-asmtp001.me.com>; Sun, 09 Apr 2017 08:12:18 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=4d515a; t=1491725538; bh=kGzK2dSWXEL7PDU/fEfFVBvd+FvXoBDLvXGsyUroNvw=; h=From:Message-id:Content-type:MIME-version:Subject:Date:To; b=VOmlUlKeGTrTvfSMlqvS6OU7uXSOchILVaGIGLu+LhXzOF0dZAqaZ3/ynIRiHt0/S jvANv193/vtpMRiNqc4dtxf/QfChWz+ZQyImDYFI+oNWWyL3l1OHPxOwq9bEsldNCe CpiNLZszcVCJKohvYZlR5M3KrktaAahuNTxZTNGkvAVKhaa8vomtDJb49XPkTezrSV ioC05mgnRVa9GPmD5YQSBd2glaIRxnrtHKlcRKoUw+/fbnolVPbS+ea6PkZ5DXqtge CpR+u4NdkE9QxYEWnFmxlbY3+vWfOOjdIVKMat5LixKV/nuXCrB01bUFQRloUlGhhT Yc2YhGOLvSnPg== Received: from icloud.com ([127.0.0.1]) by st13p35im-asmtp001.me.com (Oracle Communications Messaging Server 7.0.5.38.0 64bit (built Feb 26 2016)) with ESMTPSA id <0OO400DSGUSEYM00@st13p35im-asmtp001.me.com>; Sun, 09 Apr 2017 08:12:17 +0000 (GMT) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-04-09_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 clxscore=1034 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1701120000 definitions=main-1704090074 From: Toomas Soome Message-id: <32C6ACC7-C1A5-4797-81E1-7F630FB94D14@me.com> MIME-version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: svn commit: r316585 - in head/sys/boot: efi/boot1 efi/loader i386/common i386/loader i386/zfsboot zfs Date: Sun, 09 Apr 2017 11:12:14 +0300 In-reply-to: <20170408221653.qtqdvgcosguvugtt@mutt-hbsd> Cc: Toomas Soome , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org To: Shawn Webb References: <201704061817.v36IHT8i088712@repo.freebsd.org> <20170408221653.qtqdvgcosguvugtt@mutt-hbsd> X-Mailer: Apple Mail (2.3273) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Apr 2017 08:12:19 -0000 > On 9. apr 2017, at 1:16, Shawn Webb = wrote: >=20 > On Thu, Apr 06, 2017 at 06:17:29PM +0000, Toomas Soome wrote: >> Author: tsoome >> Date: Thu Apr 6 18:17:29 2017 >> New Revision: 316585 >> URL: https://svnweb.freebsd.org/changeset/base/316585 >>=20 >> Log: >> loader: zfs reader should check all labels >>=20 >> The current zfs reader is only checking first label from each = device, however, >> we do have 4 labels on device and we should check all 4 to be = protected >> against disk failures and incomplete label updates. >>=20 >> The difficulty is about the fact that 2 label copies are in front of = the >> pool data, and 2 are at the end, which means, we have to know the = size of >> the pool data area. >>=20 >> Since we have now the mechanism from common/disk.c to use the = partition >> information, it does help us in this task; however, there are still = some >> corner cases. >>=20 >> Namely, if the pool is created without partition, directly on the = disk, >> and firmware will give us the wrong size for the disk, we only can = check >> the first two label copies. >>=20 >> Reviewed by: allanjude >> Differential Revision: https://reviews.freebsd.org/D10203 >=20 > This breaks bhyve userboot: >=20 > # sh /usr/share/examples/bhyve/vmrun.sh -c 8 -m 16g -t tap4 -C = /dev/nmdm-laptop-dev-03-A -d = /dev/zvol/enctank/bhyve/laptop-dev-03/disk-01 laptop-dev-03 > /boot/userboot.so: Undefined symbol "ldi_get_size" >=20 > Thanks, >=20 > --=20 > Shawn Webb > Cofounder and Security Engineer > HardenedBSD >=20 > GPG Key ID: 0x6A84658F52456EEE > GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 = 6EEE Yep, the fix is posted as part of https://reviews.freebsd.org/D10302 = - I=E2=80=99m currently running the = build to double check and I think I=E2=80=99ll make the userboot commit = as soon as it is verified. Sorry for the mess. rgds, toomas