From owner-cvs-all Tue Jan 16 5:52: 4 2001 Delivered-To: cvs-all@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id 21FFF37B401; Tue, 16 Jan 2001 05:51:39 -0800 (PST) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id AAA06926; Wed, 17 Jan 2001 00:51:35 +1100 Date: Wed, 17 Jan 2001 00:51:40 +1100 (EST) From: Bruce Evans X-Sender: bde@besplex.bde.org To: "David O'Brien" Cc: Garrett Wollman , Maxim Sobolev , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libvgl bitmap.c main.c simple.c vgl.h In-Reply-To: <20010115143602.A44766@dragon.nuxi.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Mon, 15 Jan 2001, David O'Brien wrote: > On Mon, Jan 15, 2001 at 02:43:43PM -0500, Garrett Wollman wrote: > > >> > -void VGLSetXY(VGLBitmap *object, int x, int y, byte color); > > >> > +void VGLSetXY(VGLBitmap *object, int x, int y, u_long color); > > > > > Please bump shared library version number, because ABI is likely to be broken. > > > > Changes of this sort clearly do *not* break the ABI on Intel > > architecture (the parameter `color' is in the same place on the stack, > > Not for 64-bit longs on x86... Heh. I don't think there's an official ABI for those. I've never seen one for ordinary longs. In practice, gcc pessimizes both the caller and the callee for passing types smaller than ints. The caller extends the value and the callee truncates the value. Only one side needs to be pessimized to support the C standard (if a prototype for the callee is in scope). Pessimizing both sides helps support mixing code compiled by different compilers and may be required by ABI's. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message