From owner-freebsd-hackers@FreeBSD.ORG Mon Jan 22 15:46:12 2007 Return-Path: X-Original-To: hackers@freebsd.org Delivered-To: freebsd-hackers@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 25BE816A409; Mon, 22 Jan 2007 15:46:12 +0000 (UTC) (envelope-from steve@Watt.COM) Received: from wattres.watt.com (wattres.watt.com [66.93.133.130]) by mx1.freebsd.org (Postfix) with ESMTP id E057A13C442; Mon, 22 Jan 2007 15:46:11 +0000 (UTC) (envelope-from steve@Watt.COM) Received: from wattres.watt.com (localhost.watt.com [127.0.0.1]) by wattres.watt.com (8.13.8/8.13.8) with ESMTP id l0MFk36t081899; Mon, 22 Jan 2007 07:46:08 -0800 (PST) (envelope-from steve@wattres.watt.com) Received: (from steve@localhost) by wattres.watt.com (8.13.8/8.13.8/Submit) id l0MFk27m081898; Mon, 22 Jan 2007 07:46:02 -0800 (PST) (envelope-from steve) Message-Id: <200701221546.l0MFk27m081898@wattres.watt.com> From: steve@Watt.COM (Steve Watt) Date: Mon, 22 Jan 2007 07:46:02 -0800 In-Reply-To: Uwe Doering "Re: Interesting TCP issue" (Jan 22, 9:15) X-Mailer: Mail User's Shell (7.2.6 beta(5) 10/07/98) To: Uwe Doering , Steve Watt X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (wattres.watt.com [127.0.0.1]); Mon, 22 Jan 2007 07:46:08 -0800 (PST) X-Archived: 1169480768.350534846@wattres.Watt.COM Cc: hackers@freebsd.org, andre@freebsd.org, julian@elischer.org Subject: Re: Interesting TCP issue X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jan 2007 15:46:12 -0000 On Jan 22, 9:15, Uwe Doering wrote: } Subject: Re: Interesting TCP issue } Steve Watt wrote: } > In <459AD141.5010502@elischer.org>, Julian Elischer wrote: } > } > [ Snip discussion of symptoms of window scaling broken when } > talking to at least the skype mail servers. ] } > } >> we have seen this since 4.x } >> I think a fix may be in 7.0 but I'm not sure.. } >> I thin kthere is a problem when the far end sets the window down to 1 } >> but scales it by a factor of 2^{big number}. } >> } >> Andre, can you check out this problem and MFC the correct fix } >> if it is indeed the same problem in 6.2? } > } > It is the same problem; I took the (one-line) fix as indicated by } > } >> http://cvs.ironport.com/cgi-bin/viewcvs.cgi/freebsd/src/sys/netinet/tcp_syncache.c.diff?r1=1.84&r2=1.85 } > } > (well, not cvs.ironport.com, which doesn't seem to exist at the moment), } > and applied the diff from 1.84 to } > 1.85 and to a 6.2-PRERELEASE box updated around 25 Dec 06. } > It works like a charm. } > } > I would vote to MFC 1.85 now that 6.2 is out. } } I wonder whether it is that easy. As far as I can tell the commit to } HEAD actually comprised changes to three files: I wonder as well, but that single diff fixes the problem I was running into with the skype mail servers. } http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/netinet/tcp_input.c.diff?r1=1.290&r2=1.291 } http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/netinet/tcp_syncache.c.diff?r1=1.84&r2=1.85 } http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/netinet/tcp_var.h.diff?r1=1.127&r2=1.128 } } How about the modifications in 'tcp_input.c'? Are they relevant to the } problem this thread is about? If so, assessing the correctness of an } MFC might prove to be a little harder. Looking at it, yeah, those probably need to be picked up in some form as well. I didn't look closely at the tcpdump after, only observing that it worked where it didn't before. Hmm. -- Steve Watt KD6GGD PP-ASEL-IA ICBM: 121W 56' 57.5" / 37N 20' 15.3" Internet: steve @ Watt.COM Whois: SW32-ARIN Free time? There's no such thing. It just comes in varying prices...