From owner-cvs-src@FreeBSD.ORG Wed Sep 22 06:02:10 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EC36916A4CE; Wed, 22 Sep 2004 06:02:10 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E079D43D5A; Wed, 22 Sep 2004 06:02:10 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i8M62ASW011469; Wed, 22 Sep 2004 06:02:10 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i8M62AGf011468; Wed, 22 Sep 2004 06:02:10 GMT (envelope-from imp) Message-Id: <200409220602.i8M62AGf011468@repoman.freebsd.org> From: Warner Losh Date: Wed, 22 Sep 2004 06:02:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/usb usb_port.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Sep 2004 06:02:11 -0000 imp 2004-09-22 06:02:10 UTC FreeBSD src repository Modified files: sys/dev/usb usb_port.h Log: Add a temporary workaround to the panic on boot with hub attached and panic on hub detach bugs that have been reported. This work around detaches the device before deleting it. This changes the detach order from in-order to pre-order. This avoids uhub's deleting the children after its subdevs has been deleted. This is only a workaround. This leads to a strange condition in the device tree where attached devices are children of detached ones. I really don't know what that's supposed to mean, but does violate my sense of POLA. Fortunately, the violation is short lived, which is why I'm going ahead and committing the work around. # We really need to consider life w/o the multiple nested layers of # compatibility macros. They make finding bugs like this *MUCH* # harder. Patch by: iadowse MT5 before: next_release(5.3-BETA5) (unless someting better comes along) Revision Changes Path 1.68 +1 -0 src/sys/dev/usb/usb_port.h