From owner-svn-src-head@FreeBSD.ORG Thu Sep 12 00:14:26 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 3F5D8C18; Thu, 12 Sep 2013 00:14:26 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 2E2B22225; Thu, 12 Sep 2013 00:14:26 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.7/8.14.7) with ESMTP id r8C0EPXx057767; Thu, 12 Sep 2013 00:14:25 GMT (envelope-from delphij@svn.freebsd.org) Received: (from delphij@localhost) by svn.freebsd.org (8.14.7/8.14.5/Submit) id r8C0EPvW057766; Thu, 12 Sep 2013 00:14:25 GMT (envelope-from delphij@svn.freebsd.org) Message-Id: <201309120014.r8C0EPvW057766@svn.freebsd.org> From: Xin LI Date: Thu, 12 Sep 2013 00:14:25 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r255483 - head/usr.sbin/mtree X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Sep 2013 00:14:26 -0000 Author: delphij Date: Thu Sep 12 00:14:25 2013 New Revision: 255483 URL: http://svnweb.freebsd.org/changeset/base/255483 Log: Do not emit size for non-regular files. There is nothing that mtree(1) can do in this situation and would cause confusion. MFC candidate. Approved by: re (hrs) Modified: head/usr.sbin/mtree/create.c Modified: head/usr.sbin/mtree/create.c ============================================================================== --- head/usr.sbin/mtree/create.c Wed Sep 11 23:36:56 2013 (r255482) +++ head/usr.sbin/mtree/create.c Thu Sep 12 00:14:25 2013 (r255483) @@ -208,7 +208,7 @@ statf(int indent, FTSENT *p) output(indent, &offset, "mode=%#o", p->fts_statp->st_mode & MBITS); if (keys & F_NLINK && p->fts_statp->st_nlink != 1) output(indent, &offset, "nlink=%u", p->fts_statp->st_nlink); - if (keys & F_SIZE) + if (keys & F_SIZE && S_ISREG(p->fts_statp->st_mode)) output(indent, &offset, "size=%jd", (intmax_t)p->fts_statp->st_size); if (keys & F_TIME)