From owner-freebsd-current  Sun Jun 23  2: 4:46 2002
Delivered-To: freebsd-current@freebsd.org
Received: from storm.FreeBSD.org.uk (storm.FreeBSD.org.uk [194.242.139.170])
	by hub.freebsd.org (Postfix) with ESMTP id 5ABAC37B403
	for <current@freebsd.org>; Sun, 23 Jun 2002 02:04:38 -0700 (PDT)
Received: from storm.FreeBSD.org.uk (uucp@localhost [127.0.0.1])
	by storm.FreeBSD.org.uk (8.12.3/8.12.3) with ESMTP id g5N94V8r028254;
	Sun, 23 Jun 2002 10:04:31 +0100 (BST)
	(envelope-from mark@grimreaper.grondar.org)
Received: (from uucp@localhost)
	by storm.FreeBSD.org.uk (8.12.3/8.12.3/Submit) with UUCP id g5N94Vfq028253;
	Sun, 23 Jun 2002 10:04:31 +0100 (BST)
Received: from grimreaper.grondar.org (localhost [127.0.0.1])
	by grimreaper.grondar.org (8.12.4/8.12.4) with ESMTP id g5MLsva4041792;
	Sat, 22 Jun 2002 22:54:57 +0100 (BST)
	(envelope-from mark@grimreaper.grondar.org)
Message-Id: <200206222154.g5MLsva4041792@grimreaper.grondar.org>
To: Jonathan Belson <jon@witchspace.com>
Cc: current@freebsd.org
Subject: Re: Perl scripts that need rewiting - Any volunteers? 
References: <3D0A464B.7040904@witchspace.com> 
In-Reply-To: <3D0A464B.7040904@witchspace.com> ; from Jonathan Belson <jon@witchspace.com>  "Fri, 14 Jun 2002 20:38:51 BST."
Date: Sat, 22 Jun 2002 22:54:56 +0100
From: Mark Murray <mark@grondar.za>
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

> Mark Murray wrote:
> >>These seem to be the same program.  I'll take this if there are no
> >>objections. 
> > 
> > You have it!
> 
> Okay, here's my vidfont/kbdmap rewrite for review.  Any feedback
> is welcome, the same goes for bug reports :-)

Cool, thank you very much!

Some comments:

o Please put a copyright on the top of this. By preference, please use
  /usr/share/examples/etc/bsd-style-copyright.

o The code style is generally good, but please don't put braces around
  single lines of code, ie use
  for (;;)
	stuff;
  rather than
  for (;;) {
	stuff;
  }

o Please put all the macro strings like default font and directories into
  macros and #include those from (say) vidfont.h.

o Please shorten any long line or comment to less than 80 columns

o Please do not use mktemp(); use mkstemp() instead.

o Please make this WARNS=6 clean as far as is possible.

Thanks!

M
-- 
o       Mark Murray
\_
O.\_    Warning: this .sig is umop ap!sdn

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message