From owner-freebsd-ipfw@FreeBSD.ORG  Wed Jun  1 19:50:04 2011
Return-Path: <owner-freebsd-ipfw@FreeBSD.ORG>
Delivered-To: freebsd-ipfw@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0DC2C106564A
	for <freebsd-ipfw@hub.freebsd.org>;
	Wed,  1 Jun 2011 19:50:04 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id F1AFD8FC13
	for <freebsd-ipfw@hub.freebsd.org>;
	Wed,  1 Jun 2011 19:50:03 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p51Jo336040320
	for <freebsd-ipfw@freefall.freebsd.org>; Wed, 1 Jun 2011 19:50:03 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p51Jo3VK040319;
	Wed, 1 Jun 2011 19:50:03 GMT (envelope-from gnats)
Date: Wed, 1 Jun 2011 19:50:03 GMT
Message-Id: <201106011950.p51Jo3VK040319@freefall.freebsd.org>
To: freebsd-ipfw@FreeBSD.org
From: dfilter@FreeBSD.ORG (dfilter service)
Cc: 
Subject: Re: kern/147720: commit references a PR
X-BeenThere: freebsd-ipfw@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: IPFW Technical Discussions <freebsd-ipfw.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ipfw>,
	<mailto:freebsd-ipfw-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ipfw>
List-Post: <mailto:freebsd-ipfw@freebsd.org>
List-Help: <mailto:freebsd-ipfw-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ipfw>,
	<mailto:freebsd-ipfw-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Jun 2011 19:50:04 -0000

The following reply was made to PR kern/147720; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/147720: commit references a PR
Date: Wed,  1 Jun 2011 19:45:02 +0000 (UTC)

 Author: ae
 Date: Wed Jun  1 19:44:52 2011
 New Revision: 222582
 URL: http://svn.freebsd.org/changeset/base/222582
 
 Log:
   O_FORWARD_IP is only action which depends from the result of lookup of
   dynamic rules. We are doing forwarding in the following cases:
    o For the simple ipfw fwd rule, e.g.
   
   	fwd 10.0.0.1 ip from any to any out xmit em0
   	fwd 127.0.0.1,3128 tcp from any to any 80 in recv em1
   
    o For the dynamic fwd rule, e.g.
   
    	fwd 192.168.0.1 tcp from any to 10.0.0.3 3333 setup keep-state
   
           When this rule triggers it creates a dynamic rule, but this
   	dynamic rule should forward packets only in forward direction.
   
    o And the last case that does not work before - simple fwd rule which
    triggers when some dynamic rule is already executed.
   
   PR:		kern/147720, kern/150798
   MFC after:	1 month
 
 Modified:
   head/sys/netinet/ipfw/ip_fw2.c
 
 Modified: head/sys/netinet/ipfw/ip_fw2.c
 ==============================================================================
 --- head/sys/netinet/ipfw/ip_fw2.c	Wed Jun  1 18:42:44 2011	(r222581)
 +++ head/sys/netinet/ipfw/ip_fw2.c	Wed Jun  1 19:44:52 2011	(r222582)
 @@ -2118,7 +2118,8 @@ do {								\
  			case O_FORWARD_IP:
  				if (args->eh)	/* not valid on layer2 pkts */
  					break;
 -				if (!q || dyn_dir == MATCH_FORWARD) {
 +				if (q == NULL || q->rule != f ||
 +				    dyn_dir == MATCH_FORWARD) {
  				    struct sockaddr_in *sa;
  				    sa = &(((ipfw_insn_sa *)cmd)->sa);
  				    if (sa->sin_addr.s_addr == INADDR_ANY) {
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"