From nobody Tue Jan 9 18:58:20 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T8gDs1V75z56FxQ; Tue, 9 Jan 2024 18:58:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T8gDs10W9z4bpp; Tue, 9 Jan 2024 18:58:21 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704826701; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ywSNpW5bRnt9NtlUVSegyRoL1DBvRJ0GFFWMCDIj/T8=; b=OTvSJuZhJliVrWiZ9rYOI/MgTlMy99H9e/Cemwx6IX/ISb3TWcAfVGWLJLwFiRVUKKiIfC RmZ0wQfYJUJHPyt0JKjI947ks3AVm6/cNw+NxL4IH4Ni6DfH+5ikaY0DH9BI8FMUA4zbwS b86xwZOMIsg5DCmZMt6FNXwIk3UXaT3r4B2kJgs5RVMpWtvLI6lLxGtp5DA0kW9XGqxQl4 eg1i5OZNlajpvr4HEfv8YvSMJTE/ig7Jg0JWbUEEjvB8VMa3o0kfo5k1ruVrciS6kWTf0P X0LLNwwJZyKwbEvKkak5vKe4slCtE+5iZFwpxaP5IU73Lty5SBic4RPhavEfig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704826701; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ywSNpW5bRnt9NtlUVSegyRoL1DBvRJ0GFFWMCDIj/T8=; b=SxexQP8JY+fwDHyKgkXJI3dqNt7b+e1UF5onW6QEqVR4Ll5Nf3bqQ8ZWTQ5kPl+Y1nSM3L 8fAbOLlhr04Q604/N0c68P4qOUzaR9L+CtVfWU1/XJFL3CASTaNF0XiwgHNyzqktJ9VTXN TJ1HmskC113WxAFWxpVFWeFd9SmYRCcK54kov83ljzEkYK1U54wnWLWdnAtp3F7HKviseu b6DyP4bTY0/f6cQigblHo14P2RfhSoj26oK4nuOG/zYSfcH/TebydYhF75okXWXa3GEJWb XBzKoCB0Ry9zeOy0n+qQEYQfQHA+/Hx8H4Jle5owx2dTcSVji8D/Ocp+30TAzg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704826701; a=rsa-sha256; cv=none; b=ScqhbHj99gOpr5Epazwc3K3MvX7esiItTpgC03rkVv5dH1AvbcOjbi+rrDWrs7SGE8e8Ud m7ooTwkPmFotzR427zUG99Oi434f2vMosfMPGF7zniTakW86RiIqkwpF8byCU5Ejd3uHR/ tPVBZ13wGKB95Mdjh0/uQ2hUyFJgQ6MHYb/7GsKOceDYrY0wIGGvhEHxzcHeYQZ3kv/+UU gnZsaafMHZ2oRrEhkYzzc+X/YqY9QM+ekTUVU4/Gf1LlGmGbVHsL47/BshilLWO8clZapt l7n/1b4IvKtM07XO/SBA/Vn4CiKrsq0h6+Wk5hX8/3vXCUgofEpDbbTKsQ3P9w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T8gDs033Jz12hl; Tue, 9 Jan 2024 18:58:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 409IwK29081455; Tue, 9 Jan 2024 18:58:20 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 409IwKlf081453; Tue, 9 Jan 2024 18:58:20 GMT (envelope-from git) Date: Tue, 9 Jan 2024 18:58:20 GMT Message-Id: <202401091858.409IwKlf081453@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: 6631e2f9b49e - main - kldxref: Workaround incorrect PT_DYNAMIC in existing powerpc kernels List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6631e2f9b49e08f53c7beb560ee8509c343b3927 Auto-Submitted: auto-generated The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=6631e2f9b49e08f53c7beb560ee8509c343b3927 commit 6631e2f9b49e08f53c7beb560ee8509c343b3927 Author: John Baldwin AuthorDate: 2024-01-09 18:57:48 +0000 Commit: John Baldwin CommitDate: 2024-01-09 18:57:48 +0000 kldxref: Workaround incorrect PT_DYNAMIC in existing powerpc kernels Existing powerpc kernels include additional sections beyond .dynamic in the PT_DYNAMIC segment. Relax the requirement for an exact size match of the section and segment for PowerPC files as a workaround. Reported by: jrtc27 Sponsored by: DARPA Differential Revision: https://reviews.freebsd.org/D43123 --- usr.sbin/kldxref/ef.c | 11 ++++++++++- usr.sbin/kldxref/ef.h | 1 + 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/usr.sbin/kldxref/ef.c b/usr.sbin/kldxref/ef.c index fd0782ff1dd0..1ef27f2bc54a 100644 --- a/usr.sbin/kldxref/ef.c +++ b/usr.sbin/kldxref/ef.c @@ -248,8 +248,17 @@ ef_parse_dynamic(elf_file_t ef, const GElf_Phdr *phdyn) dynamic_idx = -1; for (i = 0; i < nshdr; i++) { if (shdr[i].sh_type == SHT_DYNAMIC) { + /* + * PowerPC kernels contain additional sections + * beyond .dynamic in PT_DYNAMIC due to a linker + * script bug. Permit a section with a smaller + * size as a workaround. + */ if (shdr[i].sh_offset != phdyn->p_offset || - shdr[i].sh_size != phdyn->p_filesz) { + ((elf_machine(ef->ef_efile) == EM_PPC || + elf_machine(ef->ef_efile) == EM_PPC64) ? + shdr[i].sh_size > phdyn->p_filesz : + shdr[i].sh_size != phdyn->p_filesz)) { warnx(".dynamic section doesn't match phdr"); error = EFTYPE; goto out; diff --git a/usr.sbin/kldxref/ef.h b/usr.sbin/kldxref/ef.h index 2909704bf2d1..25dc5216b169 100644 --- a/usr.sbin/kldxref/ef.h +++ b/usr.sbin/kldxref/ef.h @@ -100,6 +100,7 @@ struct elf_file { int ef_fd; }; +#define elf_machine(ef) ((ef)->ef_hdr.e_machine) #define elf_class(ef) ((ef)->ef_hdr.e_ident[EI_CLASS]) #define elf_encoding(ef) ((ef)->ef_hdr.e_ident[EI_DATA])