From owner-freebsd-bugs@freebsd.org Thu Feb 25 08:43:27 2021 Return-Path: Delivered-To: freebsd-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B368755B64E for ; Thu, 25 Feb 2021 08:43:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4DmRC34Wbpz3tCn for ; Thu, 25 Feb 2021 08:43:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 995C755B64D; Thu, 25 Feb 2021 08:43:27 +0000 (UTC) Delivered-To: bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9922A55B64C for ; Thu, 25 Feb 2021 08:43:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DmRC33sBCz3t7S for ; Thu, 25 Feb 2021 08:43:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 77C30147CE for ; Thu, 25 Feb 2021 08:43:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11P8hRDp031629 for ; Thu, 25 Feb 2021 08:43:27 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11P8hRLA031628 for bugs@FreeBSD.org; Thu, 25 Feb 2021 08:43:27 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 253839] sys/buf.h uses bool type that can be undefined since commit 2bfd8992c7c7 Date: Thu, 25 Feb 2021 08:43:27 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: madpilot@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter cc flagtypes.name attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Feb 2021 08:43:27 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253839 Bug ID: 253839 Summary: sys/buf.h uses bool type that can be undefined since commit 2bfd8992c7c7 Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: bin Assignee: bugs@FreeBSD.org Reporter: madpilot@FreeBSD.org CC: kib@FreeBSD.org Attachment #222811 maintainer-approval?(kib@FreeBSD.org) Flags: CC: kib@FreeBSD.org Created attachment 222811 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D222811&action= =3Dedit Add include defining bool types. I was upgrading to recent head and I got this error when compiling port devel/libgtop in poudriere: In file included from procmap.c:54: In file included from /usr/include/ufs/ufs/inode.h:50: /usr/include/sys/buf.h:569:1: error: unknown type name 'bool' bool inmem(struct vnode *, daddr_t); ^ procmap.c:101:25: warning: unused variable 'um' [-Wunused-variable] struct ufsmount um; ^ procmap.c:405:16: warning: cast from 'gchar *' (aka 'char *') to 'glibtop_map_entry *' (aka 'struct _glibtop_map_entry *') increases required alignment from 1 to 8 [-Wcast-align] return (glibtop_map_entry*) g_array_free(maps, FALSE); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2 warnings and 1 error generated. gmake[4]: *** [Makefile:573: procmap.lo] Error 1 gmake[4]: *** Waiting for unfinished jobs.... Looking at sources I noticed commit 2bfd8992c7c7 adding that bool type to sys/buf.h I'm not sure what the correct cure is. I noticed other system sources inclu= ding buf.h generally include sys/types.h that defines bool types for c. I think buf.h should include that one directly since it uses a type defined there. I'm attaching a patch to this effect. --=20 You are receiving this mail because: You are the assignee for the bug.=