Date: Sat, 29 Aug 2009 17:25:07 +0300 From: Peter Pentchev <roam@ringlet.net> To: Attilio Rao <attilio@freebsd.org> Cc: Konstantin Belousov <kib@freebsd.org>, freebsd-arch@freebsd.org Subject: Re: [PATCH] VFS KPI/API versioning Message-ID: <20090829142507.GA1141@straylight.m.ringlet.net> In-Reply-To: <3bbf2fe10908281904l6f8119a5l2daa301016eac8ef@mail.gmail.com> References: <3bbf2fe10908281904l6f8119a5l2daa301016eac8ef@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--k1lZvvs/B4yU6o8G Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Aug 29, 2009 at 04:04:55AM +0200, Attilio Rao wrote: [snip] > Something that concerned me is also the mis-usage of the VFS_VERSION > macro, which can be easilly used at compile time in order to determine > if a feature is present or not. Basically, I have no idea by when it > doesn't get updated and if it has ever been checked in our codes. It > seems to use a random number as the start count, while it could have > been handled differently. Maybe it would be the case to start taking > care of that too, which can be an interesting tool. Quite offtopic, just a note about the "random number as the start count" part - it's not exactly random; take a "fgrep 1966" to calendar.freebsd ;) G'luck, Peter --=20 Peter Pentchev roam@ringlet.net roam@space.bg roam@FreeBSD.org PGP key: http://people.FreeBSD.org/~roam/roam.key.asc Key fingerprint FDBA FD79 C26F 3C51 C95E DF9E ED18 B68D 1619 4553 This would easier understand fewer had omitted. --k1lZvvs/B4yU6o8G Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.12 (FreeBSD) iEUEARECAAYFAkqZOkMACgkQ7Ri2jRYZRVOE2ACYs9roEnhRJRz6HB2x1gb0txtT 0ACfW9oIuc478IO+vU/x2FeU8D3+Hts= =W7Cb -----END PGP SIGNATURE----- --k1lZvvs/B4yU6o8G--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090829142507.GA1141>