From owner-freebsd-bugs  Thu Oct 25  7:10:12 2001
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 54F1837B401
	for <freebsd-bugs@hub.freebsd.org>; Thu, 25 Oct 2001 07:10:02 -0700 (PDT)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.4/8.11.4) id f9PEA2c29233;
	Thu, 25 Oct 2001 07:10:02 -0700 (PDT)
	(envelope-from gnats)
Date: Thu, 25 Oct 2001 07:10:02 -0700 (PDT)
Message-Id: <200110251410.f9PEA2c29233@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
Cc: 
From: Mitsuru IWASAKI <iwasaki@jp.FreeBSD.org>
Subject: Re: bin/31483: minor correction in error message printed by
 acpiconf.8
Reply-To: Mitsuru IWASAKI <iwasaki@jp.FreeBSD.org>
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-bugs>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-bugs>
X-Loop: FreeBSD.org

The following reply was made to PR bin/31483; it has been noted by GNATS.

From: Mitsuru IWASAKI <iwasaki@jp.FreeBSD.org>
To: cjclark@alum.mit.edu, cristjc@earthlink.net
Cc: roam@ringlet.net, freebsd-gnats-submit@FreeBSD.ORG,
	msmith@FreeBSD.ORG, iwasaki@FreeBSD.ORG, iwasaki@jp.FreeBSD.org
Subject: Re: bin/31483: minor correction in error message printed by
 acpiconf.8
Date: Thu, 25 Oct 2001 23:06:15 +0900 (JST)

 Hi,
 
 > >  On Thu, Oct 25, 2001 at 03:17:55AM +0300, Giorgos Keramidas wrote:
 > >  > 
 > >  > >Number:         31483
 > >  > >Category:       bin
 > >  > >Synopsis:       minor correction in error message printed by acpiconf.8
 > >  > >Originator:     Giorgos Keramidas
 > >  > >Release:        FreeBSD 5.0-CURRENT i386
 > >  
 > >  [snip]
 > >  
 > >  > -		err(1, NULL);
 > >  > +		err(1, ACPIDEV);
 > >  
 > >  Just as an idea.. err(1, "%s", ACPIDEV)? :)
 > 
 > ACPIDEV is a #define'd constant string. It is not a security
 > vulnerability to use it as the original poster did. The original
 > poster's code is,
 > 
 >   err(1, "/dev/acpi");
 > 
 > By the time the compiler gets to it. No format string vulnerability.
 > 
 > Anyway, here is a general err.h and sysexits.h cleanup of the program
 > that I'll commit if msmith and iwasaki don't mind,
 
 Thanks taking care of this, I don't mind so please commit :-)
 
 Thanks again

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message