Date: Mon, 15 May 1995 00:31:18 -0700 (PDT) From: "Rodney W. Grimes" <rgrimes@gndrsh.aac.dev.com> To: vode@freud.hut.fi (Kai Vorma) Cc: nate@trout.sri.MT.net, ache@freefall.cdrom.com, CVS-commiters@freefall.cdrom.com, cvs-usrbin@freefall.cdrom.com Subject: Re: cvs commit: src/usr.bin/rpcgen rpc_parse.c Message-ID: <199505150731.AAA05385@gndrsh.aac.dev.com> In-Reply-To: <Pine.HPP.3.91.950515090939.6388B-100000@freud.hut.fi> from "Kai Vorma" at May 15, 95 09:28:56 am
next in thread | previous in thread | raw e-mail | index | archive | help
> > > > On Sun, 14 May 1995, Nate Williams wrote: > > > Andrey A. Chernov writes: > > > ache 95/05/14 17:03:33 > > > > > > Modified: usr.bin/rpcgen rpc_parse.c > > > Log: > > > End of listcan be not marked, fix it > > > Submitted by: Kai Vorma <vode@snakemail.hut.fi> > > > > I looked at this fix, and I'm not sure that the proposed 'fix' was > > necessary. Did you look at the fix at determine if it was indeed needed? > > Without this fix the last plist->next link is uninitialized. rpcgen > still works, because the way BSD malloc works (it cannot reuse freed > memory so it asks more from the system and that memory is zeroed -> > next-link happens to be NULL). > > I have replaced the system malloc with a better one and rpcgen > dumps core without this patch. Then this is not a critical bug fix, becuase as ship freebsd does not have the bug! Are you *absolutely* sure your change has no side effects that would cause something else to break? If so I can live with this change, if not, I am probably going to step a cvs admin -o maj.min on rpc_parse.c and obsolete this last change until after the release is done. -- Rod Grimes rgrimes@gndrsh.aac.dev.com Accurate Automation Company Custom computers for FreeBSD
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199505150731.AAA05385>