Date: Mon, 23 Jan 2006 18:40:07 GMT From: Roland Smith <rsmith@xs4all.nl> To: freebsd-doc@FreeBSD.org Subject: Re: docs/90362: [patch] enhancement of devfs.rules manpage. Message-ID: <200601231840.k0NIe7ru022627@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR docs/90362; it has been noted by GNATS. From: Roland Smith <rsmith@xs4all.nl> To: Giorgos Keramidas <keramida@freebsd.org> Cc: bug-followup@freebsd.org Subject: Re: docs/90362: [patch] enhancement of devfs.rules manpage. Date: Mon, 23 Jan 2006 19:39:01 +0100 --6c2NcOVqGQ03X4Wi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 23, 2006 at 03:30:02AM +0200, Giorgos Keramidas wrote: > > --- devfs.rules.5 2005/12/13 19:59:29 1.6 > > +++ devfs.rules.5 2005/12/13 21:19:53 >=20 > > .Pp > > +.Dl "[localrules=3D10]" > > .Dl "add path 'da*s*' mode 0660 group usb" > > .Pp > > +The first line declares and starts a new ruleset, with the name > > +.Va localrules > > +and the number 10. Rulesets should have a unique name and number. All >=20 > "Rulesets should have a unique name and number" is duplicated here, > since it's also mentioned higher up, in the DESCRIPTION section. Ok. > > +rules that follow a ruleset declaration belong to that ruleset, untill= a >=20 > "untill" is a minor typo. Oops. > Overall this is a great idea though, but I'd probably move the general > ruleset description items in the DESCRIPTION section. If the following > looks ok to you too Roland, it would be nice to have it committed I > guess: It's mostly OK, except for some small remarks below: =20 > %%% > Index: devfs.rules.5 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /home/ncvs/src/share/man/man5/devfs.rules.5,v > retrieving revision 1.2 > diff -u -r1.2 devfs.rules.5 > --- devfs.rules.5 16 Jun 2005 18:46:17 -0000 1.2 > +++ devfs.rules.5 23 Jan 2006 01:29:23 -0000 > @@ -24,7 +24,7 @@ > .\" > .\" $FreeBSD: src/share/man/man5/devfs.rules.5,v 1.2 2005/06/16 18:46:17= ru Exp $ > .\" > -.Dd May 17, 2005 > +.Dd Jan 23, 2006 > .Dt DEVFS.RULES 5 > .Os > .Sh NAME > @@ -60,6 +60,27 @@ > It is important to put path elements that contain > .Xr glob 3 > special characters between quotes. > +.Pp > +Rulesets should have a unique name and number. > +.Pp > +All rules that follow a ruleset declaration belong to that ruleset, unti= l a > +new ruleset is started. > +.Pp This should be singular, not plural, since only one ruleset can be enabled for /dev, so: -All custom rulesets have to be enabled in +One custom ruleset has to be enabled in > +.Pa /etc/rc.conf , -otherwise they won't be applied to the +otherwise it won't be applied to the > +.Pa /dev > +file system by the default system startup process. > +For example, to enable a > +.Dq Li localrules > +ruleset for the > +.Pa /dev > +file system, you would have to use something like this in your > +.Pa rc.conf > +file: > +.Bd -literal -offset indent > +devfs_system_ruleset=3D"localrules" > +.Ed > .Sh FILES > .Bl -tag -compact > .It Pa /etc/devfs.rules > @@ -72,14 +93,20 @@ > .Dq Li usb > group, the following rule may be used: > .Pp > +.Dl "[localrules=3D10]" > .Dl "add path 'da*s*' mode 0660 group usb" > .Pp > +The first line declares and starts a new ruleset, with the name > +.Va localrules > +and the number 10. > +.Pp > To make all the > .Xr uscanner 4 > devices accessible to their owner and the > .Dq Li usb > group, a similar rule may be used: > .Pp > +.Dl "[uscanner=3D20]" You should not start an extra ruleset here. The following rule is for the /dev filesystem, and should therefore belong to the "localrules" set. AFAIK, you can activate only _one_ ruleset for /dev in /etc/rc.conf via devfs_system_ruleset (see /etc/rc.d/devfs).=20 The variable devfs_set_rulesets is meant for other mountpoints. > .Dl "add path 'uscanner*' mode 0660 group usb" > .Sh SEE ALSO > .Xr glob 3 , > %%% The rest of the patch looks OK. Roland --=20 R.F.Smith (http://www.xs4all.nl/~rsmith/) Please send e-mail as plain text. public key: http://www.xs4all.nl/~rsmith/pubkey.txt --6c2NcOVqGQ03X4Wi Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFD1SLFEnfvsMMhpyURAkTlAJ4oPOreen+QpI8nS9jAJzlw5fqhYQCfYk0f jXpALGNWROBp1I0h497TeWw= =wILh -----END PGP SIGNATURE----- --6c2NcOVqGQ03X4Wi--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200601231840.k0NIe7ru022627>