From owner-freebsd-ports-bugs@FreeBSD.ORG  Tue May 24 18:10:11 2011
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B7FD2106566B
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Tue, 24 May 2011 18:10:11 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 9F2868FC18
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Tue, 24 May 2011 18:10:11 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p4OIABgB094430
	for <freebsd-ports-bugs@freefall.freebsd.org>;
	Tue, 24 May 2011 18:10:11 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p4OIABBv094429;
	Tue, 24 May 2011 18:10:11 GMT (envelope-from gnats)
Date: Tue, 24 May 2011 18:10:11 GMT
Message-Id: <201105241810.p4OIABBv094429@freefall.freebsd.org>
To: freebsd-ports-bugs@FreeBSD.org
From: Chris Rees <utisoft@gmail.com>
Cc: 
Subject: Re: ports/148777: [New Port] sysutils/qjail: Utility to deploy large
 number of jails quickly
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Chris Rees <utisoft@gmail.com>
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 24 May 2011 18:10:11 -0000

The following reply was made to PR ports/148777; it has been noted by GNATS.

From: Chris Rees <utisoft@gmail.com>
To: joeb@a1poweruser.com
Cc: bug-followup@freebsd.org, joeb1@a1poweruser.com
Subject: Re: ports/148777: [New Port] sysutils/qjail: Utility to deploy large
 number of jails quickly
Date: Tue, 24 May 2011 19:02:53 +0100

 On 24 May 2011 17:48,  <joeb@a1poweruser.com> wrote:
 > From: =A0 =A0 Chris Rees <utisoft@gmail.com>
 CMR> Hi Joe,
 CMR>
 CMR> I understand your frustration at the port taking a while to be
 CMR> committed, but you simply can't expect things to be committed when
 CMR> advice is ignored.
 CMR>
 CMR> Why are you still using ${CP} when you should be using
 CMR> ${INSTALL_DATA}, and ${CP} -r when you should be using
 CMR> ${COPYTREE_SHARE}?
 CMR>
 CMR> Why is the DISTFILES line commented rather than removed?
 CMR>
 CMR> Why aren't you handling configuration files properly [1]?
 CMR>
 CMR> Why have you included the WRKDIR in the shar?
 CMR>
 CMR> Why have you _still_ not run portlint?
 CMR>
 CMR> Also, your mailer is messing up the shar. You're better off putting it
 CMR> up on a site somewhere, I'll be happy to host a correct shar for you
 CMR> if you email it to me as a tar.
 >
 >
 >
 >
 > ################################################################
 >
 > I dont know how you came to write the above.
 > If you read the last shar post to ports/148777 you will see that all thos=
 e
 > items have been corrected.
 
 Hands up, I'm sorry, you have corrected _two_ (not all) of the issues
 -- the WRKDIR in shar issue.
 
 You still haven't run portlint, aren't handling config files properly,
 nor have you used the correct method of installing a tree of files.
 
 I've fixed these issues for you, please approve [1].
 
 Also, please fix your mailer to not use quoted-printable -- it upsets
 GNATS and means I have to cartwheel with sed and tr on your patches.
 
 Chris
 
 [1] http://www.bayofrum.net/~crees/patches/qjail.shar