From owner-freebsd-bugs@FreeBSD.ORG  Mon Feb 23 07:40:16 2004
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8201816A4CF
	for <freebsd-bugs@hub.freebsd.org>;
	Mon, 23 Feb 2004 07:40:16 -0800 (PST)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7EA1043D41
	for <freebsd-bugs@hub.freebsd.org>;
	Mon, 23 Feb 2004 07:40:16 -0800 (PST)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	i1NFeGbv000541	for <freebsd-bugs@freefall.freebsd.org>;
	Mon, 23 Feb 2004 07:40:16 -0800 (PST)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.10/8.12.10/Submit) id i1NFeGW9000534;
	Mon, 23 Feb 2004 07:40:16 -0800 (PST)
	(envelope-from gnats)
Date: Mon, 23 Feb 2004 07:40:16 -0800 (PST)
Message-Id: <200402231540.i1NFeGW9000534@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: John Baldwin <john@baldwin.cx>
Subject: Re: kern/63171: USB keyboard rollover error [ukbd.c patch]
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: John Baldwin <john@baldwin.cx>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Feb 2004 15:40:16 -0000

The following reply was made to PR kern/63171; it has been noted by GNATS.

From: John Baldwin <john@baldwin.cx>
To: freebsd-gnats-submit@FreeBSD.org, B.Candler@pobox.com
Cc:  
Subject: Re: kern/63171: USB keyboard rollover error [ukbd.c patch]
Date: Mon, 23 Feb 2004 10:34:08 -0500

 The pointer fix does not seem correct.  usbd_set_polling() does take a 
 usbd_device_handle, not an interface pointer, so the existing code is correct 
 on -current at least.  Note that on 4.x, the poll method in ukbd.c does not 
 use usbd_device_handle's but does pass the iface pointer in.  This is due to 
 the usbd code being different in current and stable.  I have committed the 
 ukbd rollover fix however.
 
 -- 
 John Baldwin <john@baldwin.cx>  <><  http://www.baldwin.cx/~john/
 "Power Users Use the Power to Serve"  =  http://www.FreeBSD.org