From owner-svn-ports-all@FreeBSD.ORG Fri Feb 7 13:25:30 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2B6A6CED; Fri, 7 Feb 2014 13:25:30 +0000 (UTC) Received: from mail-pa0-x22a.google.com (mail-pa0-x22a.google.com [IPv6:2607:f8b0:400e:c03::22a]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 9E42A1C23; Fri, 7 Feb 2014 13:25:29 +0000 (UTC) Received: by mail-pa0-f42.google.com with SMTP id kl14so3181081pab.15 for ; Fri, 07 Feb 2014 05:25:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:mime-version:content-type:from:in-reply-to:date:cc :message-id:references:to; bh=zn9z3xIYxNiJjmpO9cUO/DTgBE57eiAbIKhKlV0CRb8=; b=mQhTgoj8iBi2dFjvOb9o6KvccxpV9tHR7r3xO8TZB4V5Ipw1odDNJmJaZdvE0d28av XMI4b8Mw8v4vEJdkuwb7KfJpcXsk1XIT+v9ERzk5oUCXFYzILFSY6l1HISLk7SCTZywf j7pg9gc5kCxdvdVG9ioRxslrTRCKzh7Crzrd7QHb599XaV0q3fnrsww49RF5y0APQ+K3 5HW92mnRnnt3ByEhXymkZpqLj2RGkes/DNMaU32+CJ6iUR0CR6NFXKZ9M9hzNNh+D6iL X1BkqDs8Sp7q66VAG74s1KTvOkDPMC3Whv/sMFAwWLrSJrp0x+V9mOMrirGfqb06s5LG VHJg== X-Received: by 10.68.245.162 with SMTP id xp2mr19770910pbc.69.1391779528948; Fri, 07 Feb 2014 05:25:28 -0800 (PST) Received: from [192.168.0.105] ([210.186.114.249]) by mx.google.com with ESMTPSA id sq7sm13689334pbc.19.2014.02.07.05.25.25 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 07 Feb 2014 05:25:27 -0800 (PST) Sender: Martin Wilke Subject: Re: svn commit: r343229 - head/graphics/libgphoto2 Mime-Version: 1.0 (Mac OS X Mail 7.1 \(1827\)) Content-Type: multipart/signed; boundary="Apple-Mail=_7234B4C4-D71B-46F1-88E3-6A0C52319DA9"; protocol="application/pgp-signature"; micalg=pgp-sha1 From: Martin Wilke In-Reply-To: <52F4DBC4.1010900@marino.st> Date: Fri, 7 Feb 2014 21:25:20 +0800 Message-Id: References: <201402071306.s17D6ete020177@svn.freebsd.org> <52F4DBC4.1010900@marino.st> To: marino@freebsd.org X-Mailer: Apple Mail (2.1827) Cc: "svn-ports-head@FreeBSD.org" , "svn-ports-all@FreeBSD.org" , ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Feb 2014 13:25:30 -0000 --Apple-Mail=_7234B4C4-D71B-46F1-88E3-6A0C52319DA9 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On Feb 7, 2014, at 9:12 PM, John Marino = wrote: > On 2/7/2014 14:06, Martin Wilke wrote: >> Author: miwi >> Date: Fri Feb 7 13:06:39 2014 >> New Revision: 343229 >> URL: http://svnweb.freebsd.org/changeset/ports/343229 >> QAT: https://qat.redports.org/buildarchive/r343229/ >>=20 >> Log: >> - Update to 2.5.3.1 >>=20 >> PR: 185940 >> Submitted by: Ports Fury >>=20 >> Modified: >> head/graphics/libgphoto2/Makefile >> head/graphics/libgphoto2/distinfo >>=20 >> Modified: head/graphics/libgphoto2/Makefile >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/graphics/libgphoto2/Makefile Fri Feb 7 13:05:57 2014 = (r343228) >> +++ head/graphics/libgphoto2/Makefile Fri Feb 7 13:06:39 2014 = (r343229) >=20 >> -.if ${OPSYS} =3D=3D FreeBSD && ${OSVERSION} < 1000040 >> +.if ${OPSYS} =3D=3D "FreeBSD" && ${OSVERSION} < 1000040 >> CONFIGURE_ENV+=3D LIBUSB1_CFLAGS=3D" " LIBUSB1_LIBS=3D"-lusb" >> .endif >=20 > Was this^^^^ some kind of style violation? > The pkgsrc guys get mad if quotes are used where they are not needed. > Why were quotes added here where clearly they are optional? >=20 my bad sorry. > John +-----------------oOO--(_)--OOo-------------------------+ With best Regards, Martin Wilke (miwi_(at)_FreeBSD.org) Mess with the Best, Die like the Rest --Apple-Mail=_7234B4C4-D71B-46F1-88E3-6A0C52319DA9 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- iEYEARECAAYFAlL03sEACgkQdLJIhLHm/OllmACfSKxmh6rlDEHtPjIcJvj2kPdo 5WgAn0nhk+t+iPPS1EYB7sYQ/MS2mf45 =MvAt -----END PGP SIGNATURE----- --Apple-Mail=_7234B4C4-D71B-46F1-88E3-6A0C52319DA9--