From owner-svn-src-all@freebsd.org Tue Feb 26 01:11:48 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DC049151C1AD; Tue, 26 Feb 2019 01:11:47 +0000 (UTC) (envelope-from kmacybsd@gmail.com) Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6AB718B4D3; Tue, 26 Feb 2019 01:11:47 +0000 (UTC) (envelope-from kmacybsd@gmail.com) Received: by mail-lf1-f65.google.com with SMTP id h10so8333348lfc.12; Mon, 25 Feb 2019 17:11:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Rowckl2RJ9Z86KhzfrQeb5He+BoaFo9YslSFWZLwlmY=; b=EeAy/A+PoXgCGh3p0amzu7++ZGzu8nEEvX4SGAj0W3YRnOXumOZeKBBM3wlXVyH0V5 PVdDwYM3k0mADWe4fzcst4WwHNJn3XoMfdBaydk/yFzWXfx6NszdfGhQfng+LWbNQ/kY 1z5zyxKvMoJ4QqL1pYkY0y+bRbWfT1qlnxxx67wqsKnUMADZmTtvS0RYCM3NwNQyrvs2 Igk32ES6YP+oHkarGCDGHXHc1SXYtJz4Tcu2Q/ZAADFPXltl1KEbmUqFqyvYJTi+4gNr wd9ZbKQ8bph+GG4C6urygMgphPYXihHMI0SgBb0+V0alzPpKo9ZlN7k9r5263GESCdGN 58Gw== X-Gm-Message-State: AHQUAuY846CEMnUicVINFPuh3hiX4PJbSVi39Xmb3Qe4z4arYifErZEj w03FDXp4i76LtPqui+U/fGDCRvwjPsfh3LWcqGas+fyf X-Google-Smtp-Source: AHgI3IbhJqNfo5N8Q66J8VRea/6gSt/Fb8c0Gl+TxH4fth1lPe3gBtwd7m90lt0C2W4z9IjZ7f7ZkHo9RAzTwEhUHjg= X-Received: by 2002:a19:c90d:: with SMTP id z13mr10928755lff.126.1551143498465; Mon, 25 Feb 2019 17:11:38 -0800 (PST) MIME-Version: 1.0 References: <201902232114.x1NLE0cH085345@repo.freebsd.org> <20190225175809.GB47081@spindle.one-eyed-alien.net> In-Reply-To: <20190225175809.GB47081@spindle.one-eyed-alien.net> From: "K. Macy" Date: Mon, 25 Feb 2019 17:11:26 -0800 Message-ID: Subject: Re: svn commit: r344487 - in head/sys: conf gnu/gcov To: Brooks Davis Cc: Matt Macy , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 6AB718B4D3 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.88 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.88)[-0.880,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Feb 2019 01:11:48 -0000 > We had a brief discussion of this commit within a subset of core. This > addition of GPLv2 code is fine as the code is easily removal to a module > (per kmoore@) should the day come that we're read to evict all GPL code. I don't execute the ctors until coverage is enabled because I have to manually find the symbols. The linker doesn't actually generate a ctor section for functions in text.startup in spite of what Juniper's linker commit would lead one to believe - presumably they have a private linker script in addition to a private gcov port. Thus, it really could just work fine as a module. Nonetheless, everything to be profiled needs to be compiled with instrumentation, so separating it out makes very little sense to me. Although, I suppose ctfconvert + dtrace module is somewhat analogous. > The modest increase in activation energy for that task seems worth it > for the short-term gains of reduced integration cost (this code will > greatly improve our ZFS-on-Linux test coverage.) > > Rod rightly points out that we haven't accepted SPDX tags alone as > license statements. The standard GPL v2.0 boiler plate should be added > to this file along side the tag. I've copied the full copyright attribution that is in the corresponding files on Linux. Is there some reason why FreeBSD requires the files to be inflated with the full license text where the original lacks it? > > An additional issue is that the a warning tag was not added to > sys/conf/files. A warning along the lines of: > > warning "kernel contains GPLv2 licensed GCOV" > > needs to be added. Yup. > > This commit needed more through review. How would this be achieved:? I had several people on the review and no one had substantive feedback. > > We intend to update our license policy to require core sign off for > new GPL code to ensure we're not adding new, tightly integrated > dependencies, to document that we're doing so knowingly, and > to make sure steps aren't missed. The current document is at: > https://www.freebsd.org/internal/software-license.html -M