From owner-cvs-ports@FreeBSD.ORG  Tue Jun 16 07:40:27 2009
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@FreeBSD.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
	id 9140E1065670; Tue, 16 Jun 2009 07:40:27 +0000 (UTC)
Date: Tue, 16 Jun 2009 07:40:27 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Stanislav Sedov <stas@FreeBSD.org>
Message-ID: <20090616074027.GB9528@FreeBSD.org>
References: <200906062015.n56KF69p058985@repoman.freebsd.org>
	<20090615235111.26879c77.stas@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <20090615235111.26879c77.stas@FreeBSD.org>
User-Agent: Mutt/1.4.2.1i
Cc: Max Brazhnikov <makc@FreeBSD.org>, cvs-ports@FreeBSD.org,
	cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/net-p2p/ktorrent Makefile distinfo
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Jun 2009 07:40:28 -0000

On Mon, Jun 15, 2009 at 11:51:11PM +0400, Stanislav Sedov wrote:
> On Sat, 6 Jun 2009 20:15:06 +0000 (UTC)
> Max Brazhnikov <makc@FreeBSD.org> mentioned:
> >   Update to 3.2.2-1
> >   
> > |  PORTNAME=	ktorrent
> > |  PORTVERSION=	3.2.2
> > | +DISTVERSIONSUFFIX=-1
> > | +PORTREVISION=	1
> > |  CATEGORIES=	net-p2p kde
> > |  MASTER_SITES=	http://ktorrent.org/downloads/${PORTVERSION}/
> > |  
> > | @@ -30,6 +32,8 @@ USE_LDCONFIG=	yes
> > |  OPTIONS=	SYNDICATION "Enable RSS/Atom plugin" on \
> > |  		PLASMA "Enable Ktorrent Plasma applet" on
> > |  
> > | +WRKSRC=		${WRKDIR}/${PORTNAME}-${PORTVERSION}
> > | +
> 
> Historically, PORTREVISION has been used to reflect the local FreeBSD
> version of the port and not the upstream app version. It is usally
> better to reflect the upstream version change by using the minor version
> number, so don't experience software version updates they don't expect.

We have DISTVERSION for cases like this one.  Really simplifies things.

./danfe