From owner-cvs-all Tue May 2 17:39:47 2000 Delivered-To: cvs-all@freebsd.org Received: from mailgate.originative.co.uk (mailgate.originative.co.uk [194.217.50.228]) by hub.freebsd.org (Postfix) with ESMTP id E47AF37BC6C; Tue, 2 May 2000 17:39:38 -0700 (PDT) (envelope-from paul@originative.co.uk) Received: from originative.co.uk (lobster.originative.co.uk [194.217.50.241]) by mailgate.originative.co.uk (Postfix) with ESMTP id 95CFB1D15F; Wed, 3 May 2000 01:39:35 +0100 (BST) Message-ID: <390F7547.C0E7E546@originative.co.uk> Date: Wed, 03 May 2000 01:39:35 +0100 From: Paul Richards Organization: Originative Solutions Ltd X-Mailer: Mozilla 4.7 [en] (X11; I; FreeBSD 5.0-CURRENT i386) X-Accept-Language: en-GB, en MIME-Version: 1.0 To: Peter Wemm Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern subr_bus.c References: <200004291324.GAA66509@freefall.freebsd.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Peter Wemm wrote: > > peter 2000/04/29 06:24:36 PDT > > Modified files: > sys/kern subr_bus.c > Log: > The newer module dependency code exposes an apparent bug in the > bus/driver/kobj system. I am not 100% sure that this is the correct fix, > but it is harmless and does seem to solve the problem. At worst, it could > cause a tiny memory leak at unload time - this is better than a free(NULL) > and subsequent panic. I'm waiting for comments from Doug about this. > This may yet be backed out and fixed differently. > > The change itself is to increment the reference count on drivers in one > case where it appears to have been missed. When everything is unloaded, > kobj_class_free() was being called twice in some cases, and panicing the > second time. Ahh, that's what was causing my panics unloading klds. Paul Richards. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message