From owner-svn-src-head@freebsd.org Sun Apr 24 17:01:46 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 225D7B1BDEA for ; Sun, 24 Apr 2016 17:01:46 +0000 (UTC) (envelope-from jbeich@vfemail.net) Received: from vfemail.net (onethreetwo.vfemail.net [199.16.11.132]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D7D0A1FAC for ; Sun, 24 Apr 2016 17:01:45 +0000 (UTC) (envelope-from jbeich@vfemail.net) Received: (qmail 37210 invoked by uid 89); 24 Apr 2016 17:01:44 -0000 Received: from localhost (HELO freequeue.vfemail.net) (127.0.0.1) by localhost with (DHE-RSA-AES256-SHA encrypted) SMTP; 24 Apr 2016 17:01:44 -0000 Received: (qmail 37193 invoked by uid 89); 24 Apr 2016 17:01:26 -0000 Received: by simscan 1.3.1 ppid: 37185, pid: 37190, t: 0.1007s scanners:none Received: from unknown (HELO smtp102-2.vfemail.net) (172.16.100.62) by FreeQueue with SMTP; 24 Apr 2016 17:01:26 -0000 Received: (qmail 5744 invoked by uid 89); 24 Apr 2016 17:01:26 -0000 Received: by simscan 1.4.0 ppid: 5665, pid: 5733, t: 1.5639s scanners:none Received: from unknown (HELO nil) (amJlaWNoQHZmZW1haWwubmV0@172.16.100.27) by mail.vfemail.net with ESMTPA; 24 Apr 2016 17:01:25 -0000 From: Jan Beich To: Jens Schweikhardt Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r298537 - head/etc/rc.d References: <201604241053.u3OAr0bn072180@repo.freebsd.org> Date: Sun, 24 Apr 2016 19:01:02 +0200 In-Reply-To: <201604241053.u3OAr0bn072180@repo.freebsd.org> (Jens Schweikhardt's message of "Sun, 24 Apr 2016 10:53:00 +0000 (UTC)") Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Apr 2016 17:01:46 -0000 --=-=-= Content-Type: text/plain Jens Schweikhardt writes: > - parenthesize the "case" string for symmetry and improved > search for matching paren (e.g. with vi's %) [...] > case "${state}" in > - [oO][nN]) > + ([oO][nN]) > swapon /dev/zvol/${name} > ;; For style consistency is more important. Why this case is special unlike the rest of rc.d/* or rc.subr ? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQF8BAEBCgBmBQJXHPvPXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQjQ0MzY3NEM3RDIzNTc4NkUxNDkyQ0VF NEM3Nzg4MzQ3OURCRERCAAoJEOTHeINHnb3bfEcIAIbtP/5UT5IwJsFrq9XnnFZg tLIxr92wn0sYRP5v2a8tg9dvqvuk3g1LH/Fz4MDGP7MeTSbxcG7z1PkZor3uWkTR qSibgtFNFeO9LjZYioBYcAYfaI5fA4NHT+dX6/LCdG5XH3EtJaOwZnf+TNB/3UQv 9UrqQYKT7LGL6t5XS21WWQ7XjfxV4qMS/URfGDSxFa1d5v4wergV8eOUgxd6w2FQ WEpplEhtAGDWsdCLQxbPf3itUGuqweB5Fua0HKeT2ruzmGmzSG8PtHzZCqwU5ENW 2coPoqaR12Tg+QZgDk7PUHzOInm7sxBYCCz3cPQRP6kvZr0tBqtWcoC4PFmZl44= =M9FN -----END PGP SIGNATURE----- --=-=-=--