From owner-freebsd-x11@FreeBSD.ORG Thu Feb 13 23:32:56 2014 Return-Path: Delivered-To: freebsd-x11@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4F366C71 for ; Thu, 13 Feb 2014 23:32:56 +0000 (UTC) Received: from master.debian.org (master.debian.org [IPv6:2001:41b8:202:deb:216:36ff:fe40:4001]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 1552D11A6 for ; Thu, 13 Feb 2014 23:32:56 +0000 (UTC) Received: from localhost ([::1]) by master.debian.org with esmtp (Exim 4.80) (envelope-from ) id 1WE5m2-000412-HX; Thu, 13 Feb 2014 23:32:54 +0000 Message-ID: <52FD5625.6010604@freebsd.org> Date: Thu, 13 Feb 2014 23:32:53 +0000 From: Robert Millan User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Alex Kozlov Subject: Re: [PATCH] ignore uhid devices in X devd backend References: <52EFAC5D.8010603@freebsd.org> In-Reply-To: <52EFAC5D.8010603@freebsd.org> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-x11@freebsd.org X-BeenThere: freebsd-x11@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: X11 on FreeBSD -- maintaining and support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Feb 2014 23:32:56 -0000 On 03/02/2014 14:49, Robert Millan wrote: > > This patch removes uhid from the hw_types[] list. According to the > uhid driver description, this driver is only a fallback for devices > not supported by any other driver. > > On my system, the USB keyboard shows up as an uhid device in addition > to /dev/ukbd0, but the previous devd code misidentified it as a mouse. > > This just leads to trouble when X attempts to open() it and fails, > for the reasons described in my earlier devd_no_kbd.diff patch. This might no longer apply with the code in: http://trillian.chruetertee.ch/ports/browser/trunk/x11-servers/xorg-server/files/extra-devd which includes an open() test with fallback. (still I don't see the point of processing uhid devices, though) -- Robert Millan