From owner-cvs-all Thu Aug 13 11:06:30 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id LAA10619 for cvs-all-outgoing; Thu, 13 Aug 1998 11:06:30 -0700 (PDT) (envelope-from owner-cvs-all) Received: from nlsystems.com (nlsys.demon.co.uk [158.152.125.33]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id LAA10311; Thu, 13 Aug 1998 11:05:04 -0700 (PDT) (envelope-from dfr@nlsystems.com) Received: from herring.nlsystems.com (herring.nlsystems.com [10.0.0.2]) by nlsystems.com (8.8.8/8.8.5) with SMTP id TAA05609; Thu, 13 Aug 1998 19:04:03 +0100 (BST) Date: Thu, 13 Aug 1998 19:04:03 +0100 (BST) From: Doug Rabson To: Bruce Evans cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, dfr@FreeBSD.org Subject: Re: cvs commit: src/sys/kern subr_diskslice.c vfs_bio.c vfs_cluster.c src/sys/nfs nfs_vnops.c In-Reply-To: <199808130831.SAA09075@godzilla.zeta.org.au> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk On Thu, 13 Aug 1998, Bruce Evans wrote: > > Modified files: > > sys/kern subr_diskslice.c vfs_bio.c vfs_cluster.c > > sys/nfs nfs_vnops.c > > Log: > > Protect all modifications to v_numoutput with splbio(). > > > > Revision Changes Path > > 1.57 +7 -3 src/sys/kern/subr_diskslice.c > > 1.169 +4 -2 src/sys/kern/vfs_bio.c > > 1.68 +3 -1 src/sys/kern/vfs_cluster.c > > 1.106 +2 -2 src/sys/nfs/nfs_vnops.c > > This can't be the right fix. vwakeup() also modifies v_flag, so zillions > of of modifications of v_flag need similar changes. Perhaps keep the VBWAIT > flag and a pending v_numoutput decrement in separate variables to reduce > contention. You are probably right about v_flag needing protection but I have never seen problems that I can trace to v_flag. I got hangs due to v_numoutput corruption regularly. -- Doug Rabson Mail: dfr@nlsystems.com Nonlinear Systems Ltd. Phone: +44 181 951 1891 Fax: +44 181 381 1039