From owner-freebsd-net@FreeBSD.ORG Fri Oct 7 20:54:56 2011 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 463841065687; Fri, 7 Oct 2011 20:54:56 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id 7734A8FC0C; Fri, 7 Oct 2011 20:54:55 +0000 (UTC) Received: by wyj26 with SMTP id 26so5907275wyj.13 for ; Fri, 07 Oct 2011 13:54:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:date:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=cl6jY3s8zUxj0DHRNO0HM/oaXFqlK62nI4eZQun67vs=; b=BqmAniR62r5xmLPOKI4EMDenrGnuDjzGl0+KnvxpaUMJNk2REBJ3M9cgT/8lqghptt t5JyFeE17SomTbX3VbYp1TTUWDxdZByRIsZ8RhKCOYR1VWjf4+luP+eXVI8PfgLWjZyc YNmoeOTRWtShWTXQ0+2Zr2bZI4Nu9LSD4nmr0= Received: by 10.216.137.84 with SMTP id x62mr1236433wei.107.1318020894457; Fri, 07 Oct 2011 13:54:54 -0700 (PDT) Received: from pyunyh@gmail.com ([174.35.1.224]) by mx.google.com with ESMTPS id es5sm18104950wbb.11.2011.10.07.13.54.50 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 07 Oct 2011 13:54:53 -0700 (PDT) Received: by pyunyh@gmail.com (sSMTP sendmail emulation); Fri, 07 Oct 2011 13:52:54 -0700 From: YongHyeon PYUN Date: Fri, 7 Oct 2011 13:52:54 -0700 To: Sean Bruno Message-ID: <20111007205254.GC11808@michelle.cdnetworks.com> References: <1317315666.2777.8.camel@hitfishpass-lx.corp.yahoo.com> <1317323418.2777.14.camel@hitfishpass-lx.corp.yahoo.com> <1317343996.2777.33.camel@hitfishpass-lx.corp.yahoo.com> <1317346748.2777.36.camel@hitfishpass-lx.corp.yahoo.com> <5D267A3F22FD854F8F48B3D2B523819385F35B4738@IRVEXCHCCR01.corp.ad.broadcom.com> <1317683178.15510.25.camel@hitfishpass-lx.corp.yahoo.com> <20111007191154.GB11808@michelle.cdnetworks.com> <1318018310.27029.10.camel@hitfishpass-lx.corp.yahoo.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0OAP2g/MAC+5xKAE" Content-Disposition: inline In-Reply-To: <1318018310.27029.10.camel@hitfishpass-lx.corp.yahoo.com> User-Agent: Mutt/1.4.2.3i Cc: "freebsd-net@freebsd.org" , David Christensen , "davidch@freebsd.org" , Pyun YongHyeon Subject: Re: bce(4) with IPMI X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Oct 2011 20:54:56 -0000 --0OAP2g/MAC+5xKAE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Oct 07, 2011 at 01:11:50PM -0700, Sean Bruno wrote: > On Fri, 2011-10-07 at 12:11 -0700, YongHyeon PYUN wrote: > > > What's even more strange is that our freebsd6 instances don't have > > this > > > problem. > > > > > > > Can't explain either but probably stable/6 bce(4) may have used old > > firmware. > > Ok, I can once again reach the IPMI controller if I remove this: > > http://svnweb.freebsd.org/base/head/sys/dev/bce/if_bce.c?r1=210263&r2=210262&pathrev=210263 > > Since the driver has control over the interface, not "upping" the > interface media causes the IPMI controller to not be able to access the > network. Ugh. > Hmm, it seems the firmware relies on driver to establish a link such that blindly disabling PHY access in DOWN state seem to make firmware believe that there is a no established link. Could you try attached patch? > Sean > --0OAP2g/MAC+5xKAE Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="bce.mfm.diff" Index: sys/dev/bce/if_bce.c =================================================================== --- sys/dev/bce/if_bce.c (revision 226114) +++ sys/dev/bce/if_bce.c (working copy) @@ -6180,7 +6180,8 @@ BCE_LOCK(sc); - if ((ifp->if_flags & IFF_UP) == 0) { + if ((ifp->if_flags & IFF_UP) == 0 && + (sc->bce_flags & BCE_MFW_ENABLE_FLAG) == 0) { BCE_UNLOCK(sc); return; } --0OAP2g/MAC+5xKAE--