From owner-freebsd-hackers@FreeBSD.ORG Wed Mar 20 18:43:56 2013 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id C57CEACE; Wed, 20 Mar 2013 18:43:56 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id A49D9D2B; Wed, 20 Mar 2013 18:43:56 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id D5F99B939; Wed, 20 Mar 2013 14:43:55 -0400 (EDT) From: John Baldwin To: freebsd-current@freebsd.org Subject: Re: mountroot event Date: Wed, 20 Mar 2013 09:30:00 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p25; KDE/4.5.5; amd64; ; ) References: <514973A3.9030706@FreeBSD.org> In-Reply-To: <514973A3.9030706@FreeBSD.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201303200930.01080.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Wed, 20 Mar 2013 14:43:55 -0400 (EDT) Cc: freebsd-hackers@freebsd.org, Andriy Gapon X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Mar 2013 18:43:56 -0000 On Wednesday, March 20, 2013 4:30:27 am Andriy Gapon wrote: > > I would like to propose the following change. > > My understanding is that it was never a true intention to post 'mountroot' event > on every set_rootvnode() call, but rather an accident in the original commit. > But I could be wrong here. In either case I think that it is more appropriate > to post the event only once. I do not expect that there could be any consumers > interested in all the details of root fs manipulations. The firmware code only needs the final call for the "real" root. I think your change is fine. -- John Baldwin