From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Feb 23 06:30:05 2010 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B6902106566B for ; Tue, 23 Feb 2010 06:30:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 798B48FC14 for ; Tue, 23 Feb 2010 06:30:05 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id o1N6U5fB043787 for ; Tue, 23 Feb 2010 06:30:05 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id o1N6U5SU043783; Tue, 23 Feb 2010 06:30:05 GMT (envelope-from gnats) Resent-Date: Tue, 23 Feb 2010 06:30:05 GMT Resent-Message-Id: <201002230630.o1N6U5SU043783@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Masafumi NAKANE Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3F639106568B for ; Tue, 23 Feb 2010 06:26:35 +0000 (UTC) (envelope-from max@accessibility.org) Received: from bourbon.accessibility.org (bourbon.accessibility.org [210.226.20.19]) by mx1.freebsd.org (Postfix) with ESMTP id 0E1318FC14 for ; Tue, 23 Feb 2010 06:26:34 +0000 (UTC) Received: from bourbon.accessibility.org (localhost [127.0.0.1]) by bourbon.accessibility.org (Postfix) with ESMTP id A54EC547403 for ; Tue, 23 Feb 2010 15:26:33 +0900 (JST) Received: by bourbon.accessibility.org (Postfix, from userid 1000) id 3BA95547402; Tue, 23 Feb 2010 15:26:33 +0900 (JST) Message-Id: <20100223062633.3BA95547402@bourbon.accessibility.org> Date: Tue, 23 Feb 2010 15:26:33 +0900 (JST) From: Masafumi NAKANE To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/144223: ports/textproc/urlview installs non-text browser even when it's not needed X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Masafumi NAKANE List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Feb 2010 06:30:05 -0000 >Number: 144223 >Category: ports >Synopsis: ports/textproc/urlview installs non-text browser even when it's not needed >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Tue Feb 23 06:30:04 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Masafumi NAKANE >Release: FreeBSD 7.0-RELEASE-p5 i386 >Organization: >Environment: System: FreeBSD bourbon.accessibility.org 7.0-RELEASE-p5 FreeBSD 7.0-RELEASE-p5 #2: Fri Oct 3 16:27:21 JST 2008 root@bourbon.accessibility.org:/usr/obj/usr/src/sys/GENERIC i386 >Description: ports/textproc/urlview depends on one of Firefox, SeaMonkey, or Gecko according to WITH_* variable defined at make time. While this has no problem for desktop system where these browsers are used, this is not desirable on systems where only text browsers, such as Lynx, w3m, etc., are used. The fact that there is no easy way to specify, that you don't need any of these browsers installed and just urlview to be installed, makes the issue somewhat serious. >How-To-Repeat: >Fix: Patch below adds the config dialog so that users can specify what they need (or don't need) at build time. Index: Makefile =================================================================== RCS file: /home/pcvs/ports/textproc/urlview/Makefile,v retrieving revision 1.26 diff -u -r1.26 Makefile --- Makefile 5 Feb 2010 11:44:35 -0000 1.26 +++ Makefile 23 Feb 2010 06:18:06 -0000 @@ -25,15 +25,19 @@ SUB_FILES= gecko.sh SUB_LIST= GECKO=${GECKO} -.include +OPTIONS= GECKO "Use Gecko" off \ + SEAMONKEY "Use SeaMonkey" off \ + FIREFOX "Use Firefox" off +.include +.include .if defined(WITH_GECKO) USE_GECKO= firefox-devel firefox35 seamonkey .include "${PORTSDIR}/Mk/bsd.gecko.mk" .elif defined(WITH_SEAMONKEY) RUN_DEPENDS+= ${LOCALBASE}/lib/seamonkey/seamonkey-bin:${PORTSDIR}/www/seamonkey GECKO= seamonkey -.else +.elif defined(WITH_FIREFOX) RUN_DEPENDS+= ${LOCALBASE}/lib/firefox3/firefox:${PORTSDIR}/www/firefox35 GECKO= firefox3 .endif >Release-Note: >Audit-Trail: >Unformatted: