From owner-freebsd-hackers@FreeBSD.ORG Mon Nov 7 23:10:39 2005 Return-Path: X-Original-To: freebsd-hackers@freebsd.org Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D2C5716A41F for ; Mon, 7 Nov 2005 23:10:39 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1256A43D6E for ; Mon, 7 Nov 2005 23:10:33 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id jA7NAXwG009456; Mon, 7 Nov 2005 15:10:33 -0800 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id jA7NAWuR009455; Mon, 7 Nov 2005 15:10:32 -0800 Date: Mon, 7 Nov 2005 15:10:32 -0800 From: Brooks Davis To: Ulf Lilleengen Message-ID: <20051107231032.GA5351@odin.ac.hmc.edu> References: <20051101225848.GB20543@odin.ac.hmc.edu> <20051107225921.GA1623@samfundet.no> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="pWyiEgJYm5f9v55/" Content-Disposition: inline In-Reply-To: <20051107225921.GA1623@samfundet.no> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu Cc: freebsd-hackers@freebsd.org Subject: Re: Contributing to FreeBSD list of things todo X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Nov 2005 23:10:39 -0000 --pWyiEgJYm5f9v55/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 07, 2005 at 11:59:21PM +0100, Ulf Lilleengen wrote: > On Tue, Nov 01, 2005 at 02:58:48PM -0800, Brooks Davis wrote: > > On Tue, Nov 01, 2005 at 04:30:00PM -0600, Ben Siemon wrote: > > > I have a suggestion for things dev people could do to help out with > > > code already done. I noticed the suggestion for compiling with -Wall > > > enabled. Would it serve any purpose to compile the sources with -ansi > > > and or -pedantic as well? I am fairly new to FreeBSD so forgive me if > > > this has alread been addressed. > >=20 > > I think the todo list is dated in this area. We now compile many files > > with large sets of warning flags via the WARNS variable in Makefiles. > > It is useful to expand the coverage in this area, but it's not all that > > trivial. It's often fairly easy to make the warning go away without > > fixing the real problem the warning represented. This means that far > > too many patches to raise warning levels are useless and waste developer > > time. There's also the fact that such changes need to be tested on > > multiple architectures because certain warnings are platform specfic. > > At the least testing is needed on i386, alpha, and sparc. > >=20 > I've seen an effort to remove these warnings by setting WARNS?=3D6 . Would > this be preferable to work on, on freebsd as well? Ofcourse testing on > most architectures. Setting WARNS=3D higher and fixing the warning is useful, but we've see a lot of submissions that took more time to fix than dealing with the problem would have in the first place. The work of someone who submitted high-quality fixes consistantly, would certainly be appreciated. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --pWyiEgJYm5f9v55/ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFDb97jXY6L6fI4GtQRAspzAKDi+B74FLjDWAwtWPi+j/jBhU2uxwCgpfFb H6eI5SUiQbUL5jQQEJWSnzY= =whoh -----END PGP SIGNATURE----- --pWyiEgJYm5f9v55/--