From owner-svn-src-all@FreeBSD.ORG Wed Jan 9 09:12:20 2013 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 3A217E33; Wed, 9 Jan 2013 09:12:20 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) by mx1.freebsd.org (Postfix) with ESMTP id 9CD05B5D; Wed, 9 Jan 2013 09:12:18 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.5/8.14.5) with ESMTP id r099CH2w075309; Wed, 9 Jan 2013 13:12:17 +0400 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.5/8.14.5/Submit) id r099CHfF075308; Wed, 9 Jan 2013 13:12:17 +0400 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Wed, 9 Jan 2013 13:12:17 +0400 From: Gleb Smirnoff To: Hans Petter Selasky Subject: Re: svn commit: r245222 - head/sys/sys Message-ID: <20130109091217.GL66284@FreeBSD.org> References: <201301090909.r09999kV013794@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <201301090909.r09999kV013794@svn.freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jan 2013 09:12:20 -0000 On Wed, Jan 09, 2013 at 09:09:09AM +0000, Hans Petter Selasky wrote: H> Author: hselasky H> Date: Wed Jan 9 09:09:09 2013 H> New Revision: 245222 H> URL: http://svnweb.freebsd.org/changeset/base/245222 H> H> Log: H> Fix compile warning when using GCC: H> Comparison between signed and unsigned. H> H> MFC after: 1 week H> H> Modified: H> head/sys/sys/mbuf.h H> H> Modified: head/sys/sys/mbuf.h H> ============================================================================== H> --- head/sys/sys/mbuf.h Wed Jan 9 08:52:44 2013 (r245221) H> +++ head/sys/sys/mbuf.h Wed Jan 9 09:09:09 2013 (r245222) H> @@ -557,7 +557,7 @@ m_get2(int how, short type, int flags, i H> args.flags = flags; H> args.type = type; H> H> - if (size <= MHLEN || (size <= MLEN && (flags & M_PKTHDR) == 0)) H> + if (size <= ((int)MHLEN) || (size <= ((int)MLEN) && (flags & M_PKTHDR) == 0)) H> return ((struct mbuf *)(uma_zalloc_arg(zone_mbuf, &args, how))); H> if (size <= MCLBYTES) H> return ((struct mbuf *)(uma_zalloc_arg(zone_pack, &args, how))); The function is new and present only in head. I suggest just change its argument to u_int or size_t, instead of casting. -- Totus tuus, Glebius.