From nobody Fri Oct 20 16:26:25 2023 X-Original-To: gnome@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SBqhx5cDxz4xy1n for ; Fri, 20 Oct 2023 16:26:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SBqhx48nhz3NWC for ; Fri, 20 Oct 2023 16:26:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1697819185; a=rsa-sha256; cv=none; b=QR679S0EalTZG4O/8AeAjQSGe6H8kbBzn7GuFQL5yReXGTEhksWl7ePvRTFja6jvsyrcWI SyIyDsWMZRbQ7yPPzdsDHyTeObUnTv3PBK1q3OX8It8K/KjbfHTdm00LIESpTd50NzVdel F5E653+22nvYH4cQRs5SzpKg8vZbW2iOz0RcmoZwnVcsLnz1DKQ2ya2EB5yr4iZqrBdfi5 hguoudA7RZuUSRjk+nSgPwrMnJFYhlevGlQTnMitlh64fSd3KgaWMt5+j4Q0dZPd/Yi2RG ygZHjnYOFaNAFu+9QrEcyCOovRa2i+EtGuyXyUaXGYH7eHXliDHJRvP4+l7tcw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697819185; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QULuljbGrRaO4DCghgzkMhTF1FwDrz55ENXWSRSHdZU=; b=mxOJvbY/wjiV6XrmPyEjjKs1cmnSJ726/6aDgpEHZDnzgY6Wq21dhfcD8oB8f1SyeD2+yp 5/yB9GSEofQ74o+NEmtOkeO9eXrkKE/91d/6MB4iv0D4yI0PiQA34Rs73YwQ5Y2MEKGrqG 1Xv/dpzAeXI2MmEGrGquKvuEJ1OlptpuDybP0IBM1b+PH4oLIW4PN3F8+0QY99ppDqDkb/ iwJTWgVvO+YYe/racBTSM9Spn+3gfin31ZB0MrrQSIlVPnnXVypA56eAhfFVonUpSevPHG 7+0vJSuk922gTMMm3fXV6+ngJv+O/b63KJ0eerbYeRxu84BgKH8GvPBt+MhWBA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SBqhx3GWPzgHG for ; Fri, 20 Oct 2023 16:26:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 39KGQPn2088367 for ; Fri, 20 Oct 2023 16:26:25 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 39KGQPAf088366 for gnome@FreeBSD.org; Fri, 20 Oct 2023 16:26:25 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: gnome@FreeBSD.org Subject: [Bug 274329] x11-toolkits/libwnck3: fix warnings, and build with lld 17 Date: Fri, 20 Oct 2023 16:26:25 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: gnome@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: GNOME for FreeBSD -- porting and maintaining List-Archive: https://lists.freebsd.org/archives/freebsd-gnome List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-gnome@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D274329 --- Comment #2 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=3D36a866dfc827e21e5230a9c2aeb4e82= 75198a028 commit 36a866dfc827e21e5230a9c2aeb4e8275198a028 Author: Dimitry Andric AuthorDate: 2023-10-07 13:57:20 +0000 Commit: Dimitry Andric CommitDate: 2023-10-20 16:25:47 +0000 x11-toolkits/libwnck3: fix warnings, and build with lld 17 Building x11-toolkits/libwnck3 with lld 17 results in the following link errors: cc -o libwnck/libwnck-3.so.0.3.0 libwnck/libwnck-3.so.0.3.0.p/meson-generated_.._wnck-enum-types.c.o libwnck/libwnck-3.so.0.3.0.p/meson-generated_.._libwnck-resources.c.o libwnck/libwnck-3.so.0.3.0.p/application.c.o libwnck/libwnck-3.so.0.3.0.p/class-group.c.o libwnck/libwnck-3.so.0.3.0.p/pager.c.o libwnck/libwnck-3.so.0.3.0.p/screen.= c.o libwnck/libwnck-3.so.0.3.0.p/selector.c.o libwnck/libwnck-3.so.0.3.0.p/tasklist.c.o libwnck/libwnck-3.so.0.3.0.p/util= .c.o libwnck/libwnck-3.so.0.3.0.p/window-action-menu.c.o libwnck/libwnck-3.so.0.3.0.p/window.c.o libwnck/libwnck-3.so.0.3.0.p/wnck-image-menu-item.c.o libwnck/libwnck-3.so.0.3.0.p/workspace.c.o libwnck/libwnck-3.so.0.3.0.p/xutils.c.o libwnck/libwnck-3.so.0.3.0.p/pager-accessible.c.o libwnck/libwnck-3.so.0.3.0.p/pager-accessible-factory.c.o libwnck/libwnck-3.so.0.3.0.p/workspace-accessible.c.o libwnck/libwnck-3.so.0.3.0.p/workspace-accessible-factory.c.o -Wl,--as-need= ed -Wl,--no-undefined -Wl,-O1 -shared -fPIC -Wl,--start-group - Wl,-soname,libwnck-3.so.0 -fstack-protector-strong -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -isystem /usr/local/include -Wl,-rpath,/usr/local/lib -Wl,-rpath-link,/usr/local/lib -Wl,--version-script,/wrkdirs/share/dim/ports/x11-toolkits/libwnck3/work/li= bwnck-3.36.0/libwnck/libwnck-3.map -lm /usr/local/lib/libcairo.so /usr/local/lib/libXext.so /usr/local/lib/libXrender.so /usr/local/lib/libX11.so /usr/local/lib/libglib-2.0.so /usr/local/lib/libintl.so /usr/local/lib/libgobject-2.0.so /usr/local/lib/libgtk-3.so /usr/local/lib/libgdk-3.so /usr/local/lib/libharfbuzz.so /usr/local/lib/libpangocairo-1.0.so /usr/local/lib/libpango-1.0.so /usr/local/lib/libatk-1.0.so /usr/local/lib/libcairo-gobject.so /usr/local/lib/libgdk_pixbuf-2.0.so /usr/local/lib/libgio-2.0.so /usr/local/lib/libstartup-notification-1.so /usr/local/lib/libXRes.so -Wl,--end-group ld: error: version script assignment of 'global' to symbol '__prognam= e' failed: symbol not defined ld: error: version script assignment of 'global' to symbol 'environ' failed: symbol not defined cc: error: linker command failed with exit code 1 (use -v to see invocation) Commit bf6718d6938e added patch-libwnck_libwnck-3.map a long time ago, but it is unclear why. Remove the patch so the undefined symbols are no longer referenced in the linker script. While here, fix two warnings about incorrectly defined header guards: In file included from ../libwnck/pager-accessible-factory.c:20: ../libwnck/pager-accessible-factory.h:19:9: warning: '__WNCK_PAGER_ACCESSIBLE_FACTORY_H__' is used as a header guard here, follo= wed by #define of a different macro [-Wheader-guard] 19 | #ifndef __WNCK_PAGER_ACCESSIBLE_FACTORY_H__ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../libwnck/pager-accessible-factory.h:20:9: note: '__WBCK_PAGER_ACCESSIBLE_FACTORY_H__' is defined here; did you mean '__WNCK_PAGER_ACCESSIBLE_FACTORY_H__'? 20 | #define __WBCK_PAGER_ACCESSIBLE_FACTORY_H__ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | __WNCK_PAGER_ACCESSIBLE_FACTORY_H__ ../libwnck/workspace-accessible-factory.h:19:9: warning: '__WNCK_WORKSPACE_ACCESSIBLE_FACTORY_H__' is used as a header guard here, followed by #define of a different macro [-Wheader-guard] 19 | #ifndef __WNCK_WORKSPACE_ACCESSIBLE_FACTORY_H__ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../libwnck/workspace-accessible-factory.h:20:9: note: '__WBCK_WORKSPACE_ACCESSIBLE_FACTORY_H__' is defined here; did you mean '__WNCK_WORKSPACE_ACCESSIBLE_FACTORY_H__'? 20 | #define __WBCK_WORKSPACE_ACCESSIBLE_FACTORY_H__ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | __WNCK_WORKSPACE_ACCESSIBLE_FACTORY_H__ PR: 274329 Approved by: maintainer timeout (2 weeks) MFH: 2023Q4 .../libwnck3/files/patch-libwnck_libwnck-3.map (gone) | 11 -------= ---- .../files/patch-libwnck_pager-accessible-factory.h (new) | 11 +++++++= ++++ .../files/patch-libwnck_workspace-accessible-factory.h (new) | 11 +++++++= ++++ 3 files changed, 22 insertions(+), 11 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=