From owner-freebsd-current Wed May 29 13:40:38 2002 Delivered-To: freebsd-current@freebsd.org Received: from rwcrmhc53.attbi.com (rwcrmhc53.attbi.com [204.127.198.39]) by hub.freebsd.org (Postfix) with ESMTP id 03CB537B425; Wed, 29 May 2002 13:40:09 -0700 (PDT) Received: from InterJet.elischer.org ([12.232.206.8]) by rwcrmhc53.attbi.com (InterMail vM.4.01.03.27 201-229-121-127-20010626) with ESMTP id <20020529204009.QWIW11659.rwcrmhc53.attbi.com@InterJet.elischer.org>; Wed, 29 May 2002 20:40:09 +0000 Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id NAA18916; Wed, 29 May 2002 13:29:06 -0700 (PDT) Date: Wed, 29 May 2002 13:29:05 -0700 (PDT) From: Julian Elischer To: Matthew Dillon Cc: "David O'Brien" , John Baldwin , FreeBSD current users Subject: Re: Seeking OK to commit KSE MIII In-Reply-To: <200205292007.g4TK71YD062671@apollo.backplane.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, 29 May 2002, Matthew Dillon wrote: > > I agree that as a general rule of thumb it makes sense to commit > whitespace/paren/brace changes separately, but that is ALL it is. > A rule of thumb. It should not be followed blindly, on principle, > if it has an adverse effect on the developer tring to do the work, > and it certainly should not be made a prerequisit for having good > work comitted. I see no benefit to the project or the developer > community. > Thanks for the support Matt, though in this case I don't really mind. I've been away for the code for a while, and I am looking for things to clean-up though it to help me get "back into it" :-) so I don't mind doing a few separate commits here and there.. having said that, In this case the braces in question in ithread_schedule are: - } else + } else { curthread->td_kse->ke_flags |= KEF_NEEDRESCHED; + } I tend to always put braces on the else clause if the 'then' clause has braces.. it just helps me find the end of the if statement. The "if" statement in question was rewritten as part of KSE so Adding the braces on the else clause doesn't seem 'out of scope' to me.. It's not a tremendous obfuscation, because the clause in question needs to be considered to understand the change.. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message