From owner-p4-projects@FreeBSD.ORG  Thu Jan 18 14:37:00 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 1D76C16A415; Thu, 18 Jan 2007 14:37:00 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id C0FAE16A407
	for <perforce@freebsd.org>; Thu, 18 Jan 2007 14:36:59 +0000 (UTC)
	(envelope-from jhb@freebsd.org)
Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net
	[66.23.211.162])
	by mx1.freebsd.org (Postfix) with ESMTP id 6A32213C45A
	for <perforce@freebsd.org>; Thu, 18 Jan 2007 14:36:59 +0000 (UTC)
	(envelope-from jhb@freebsd.org)
Received: from zion.baldwin.cx (zion.baldwin.cx [192.168.0.7])
	(authenticated bits=0)
	by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id l0IEaq4k063039;
	Thu, 18 Jan 2007 09:36:52 -0500 (EST) (envelope-from jhb@freebsd.org)
From: John Baldwin <jhb@freebsd.org>
To: Jung-uk Kim <jkim@freebsd.org>
Date: Thu, 18 Jan 2007 09:17:14 -0500
User-Agent: KMail/1.9.4
References: <200701180243.l0I2hcLn035071@repoman.freebsd.org>
In-Reply-To: <200701180243.l0I2hcLn035071@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200701180917.15131.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by
	milter-greylist-2.0.2 (server.baldwin.cx [192.168.0.1]);
	Thu, 18 Jan 2007 09:36:53 -0500 (EST)
X-Virus-Scanned: ClamAV 0.88.3/2462/Thu Jan 18 05:07:46 2007 on
	server.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 
	autolearn=ham version=3.1.3
X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 113090 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Jan 2007 14:37:00 -0000

On Wednesday 17 January 2007 21:43, Jung-uk Kim wrote:
> http://perforce.freebsd.org/chv.cgi?CH=113090
> 
> Change 113090 by jkim@jkim_hammer on 2007/01/18 02:43:32
> 
> 	- Add Linux kernel version strings to /proc/sys/kernel.
> 	- Properly implement OS build date string instead of using fake one.
> 
> Affected files ...
> 
> .. //depot/projects/linuxolator/src/sys/compat/linprocfs/linprocfs.c#8 edit
> 
> Differences ...
> 
> ==== //depot/projects/linuxolator/src/sys/compat/linprocfs/linprocfs.c#8 (text+ko) ====
> 
> @@ -416,6 +416,37 @@
>  }
>  
>  /*
> + * Get OS build date
> + */
> +static void
> +linprocfs_osbuild(struct thread *td, struct sbuf *sb)
> +{
> +	char osbuild[256];
> +	int kern_ver[2];
> +	size_t size;
> +	char *cp1, *cp2;
> +
> +	cp1 = NULL;
> +	kern_ver[0] = CTL_KERN;
> +	kern_ver[1] = KERN_VERSION;
> +	osbuild[0] = '\0';
> +	size = sizeof(osbuild);
> +	if (kernel_sysctl(td, kern_ver, 2, &osbuild, &size, 0, 0, 0, 0) == 0) {
> +		cp1 = strstr(osbuild, "\n");
> +		cp2 = strstr(osbuild, ":");
> +		if (cp1 && cp2) {
> +			*cp1 = *cp2 = '\0';
> +			cp1 = strstr(osbuild, "#");
> +		} else
> +			cp1 = NULL;
> +	}
> +	if (cp1)
> +		sbuf_printf(sb, "%s%s", cp1, cp2 + 1);
> +	else
> +		sbuf_printf(sb, "#4 Sun Dec 18 04:30:00 CET 1977");
> +}

You can just reference the 'version' global variable w/o having to bounce
through the sysctl.  It's defined in <sys/systm.h>.

-- 
John Baldwin