From owner-freebsd-current@freebsd.org Tue Jul 7 22:36:45 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3C02934EEB9 for ; Tue, 7 Jul 2020 22:36:45 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-oi1-f180.google.com (mail-oi1-f180.google.com [209.85.167.180]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4B1ck459Hbz4Ck9; Tue, 7 Jul 2020 22:36:44 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-oi1-f180.google.com with SMTP id e4so28064873oib.1; Tue, 07 Jul 2020 15:36:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9X/ecV+b4YISchpbiypS7QQ9YqoUAeAO066fPOD+P1A=; b=gohCKuyHc0ZJ1j3JJGmtj2MdVFYU/zRH1qg4hi6/l5X5mI6D6Wt+I+P/B4/oN6lk2T Jj2ygLlSIRLre9I8Z58nBSLurZwITFTLzMQFDLD7qWiJl3oCmojjvBtkt2zMp7qWfpGc YpB9uB6yW4hRmdLTN1PQPP4X3Cp2YC/GnMKyiiSY0UN9pobQqByLOvpTv5XZPvuWihp6 +/O1OH/hNIzHa3iFIzrtm/fiK5t8vvUTbM2roHl9jLiulz3r3vf/lr0uMQYwwiMGlqbX urkY6syLQnwH4NQK70EOALu+ChK+D6p8MgXxSZhZ87y4225r3ZQTyUWMO9kHGT+r+oH1 ruPA== X-Gm-Message-State: AOAM531gDrgDXTxPkOYTZIZawSvz6Z3KCe3ozrQFK/1R7CKP7gGpTE/7 Yg4jRpcVyxtQwh6bbYcF/PYgJlZqmTgWAdkEJpCwFF6Mh9w= X-Google-Smtp-Source: ABdhPJzC4FeXcOYRz/poFMfbhmQxHULvaG8qAXaNt7Qpaxq6AfsupcFpOfrdVQ/XFUq8VY8bM+9CIXdka8RXoiq73oU= X-Received: by 2002:a54:4d96:: with SMTP id y22mr4725498oix.55.1594161403144; Tue, 07 Jul 2020 15:36:43 -0700 (PDT) MIME-Version: 1.0 References: <20200707222408.GA51619@raichu> In-Reply-To: <20200707222408.GA51619@raichu> From: Alan Somers Date: Tue, 7 Jul 2020 16:36:32 -0600 Message-ID: Subject: Re: Hardware crypto card wanted To: Mark Johnston Cc: FreeBSD CURRENT X-Rspamd-Queue-Id: 4B1ck459Hbz4Ck9 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jul 2020 22:36:45 -0000 Yeah, just apply the patch and run the geli tests. The patch add one additional geli test, too. IIUC, geli doesn't use the thread pool when it's using hardware crypto, which is why I think it's important that change be tested both ways. The change is here: https://reviews.freebsd.org/D25587 -Alan On Tue, Jul 7, 2020 at 4:24 PM Mark Johnston wrote: > On Tue, Jul 07, 2020 at 03:18:02PM -0600, alan somers wrote: > > I'm working on a change to geli, but I need to test it on a system with a > > hardware crypto card. Not merely one with AES-NI, but one of the old > > fashioned PCI kind that works with crypto(9). Would anybody who runs > > CURRENT on such a machine be willing to test my patch for me? > > I'm finishing work on a new hardware crypto driver and can test if you > like. Do you want to run the existing GELI tests with the patch > applied, or something else? > > I don't quite understand why GELI would care about the distinction, > though. Doesn't GELI use AES-NI via crypto(9) as well? >